MAAS

Merge lp://staging/~newell-jensen/maas/uefi-arm64 into lp://staging/~maas-committers/maas/trunk

uefi-arm64
Merge into trunk

Proposed by Newell Jensen on 2015-05-29

Status:

Merged

Approved by:

Newell Jensen on 2015-06-11

Approved revision:

no longer in the source branch.

Merged at revision:

4013

Proposed branch:

lp://staging/~newell-jensen/maas/uefi-arm64

Merge into:

lp://staging/~maas-committers/maas/trunk

Diff against target:

498 lines (+305/-58)

7 files modified

etc/maas/templates/uefi/config.local.arm64.template (+8/-0)
src/provisioningserver/boot/__init__.py (+31/-0)
src/provisioningserver/boot/tests/test_boot.py (+46/-1)
src/provisioningserver/boot/tests/test_uefi.py (+1/-36)
src/provisioningserver/boot/tests/test_uefi_arm64.py (+96/-0)
src/provisioningserver/boot/uefi.py (+1/-21)
src/provisioningserver/boot/uefi_arm64.py (+122/-0)

To merge this branch:

bzr merge lp://staging/~newell-jensen/maas/uefi-arm64

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Blake Rouse (community)		2015-05-29	Approve on 2015-06-04
Review via email: mp+260639@code.staging.launchpad.net

Commit message

Add UEFI ARM64 support to MAAS.

Revision history for this message

Blake Rouse (blake-rouse) wrote on 2015-06-01:

Looks really good. Only issue I have is with the hard-coding of ports archive. That url needs to come from MAAS global settings. Without this it will break MAAS from working offline when a user wants to deploy arm64.

review: Needs Fixing

Revision history for this message

Newell Jensen (newell-jensen) wrote on 2015-06-03:

Blake,

Have another look. I abstracted out some common logic that was also in uefi.py and put it in provisioningserver/boot/__init__.py.

Revision history for this message

Blake Rouse (blake-rouse) wrote on 2015-06-04:

Awesome! Very nice. Thanks for the fixes and cleaning it up.

Do you know if this is for 1.8 or waiting for 1.9?

review: Approve

Revision history for this message

Newell Jensen (newell-jensen) wrote on 2015-06-04:

Blake,

This can wait for 1.9. I won't land until the 1.9 window opens up.

On Thu, Jun 4, 2015 at 8:01 AM, Blake Rouse <email address hidden>
wrote:

> Review: Approve
>
> Awesome! Very nice. Thanks for the fixes and cleaning it up.
>
> Do you know if this is for 1.8 or waiting for 1.9?
> --
> https://code.launchpad.net/~newell-jensen/maas/uefi-arm64/+merge/260639
> You are the owner of lp:~newell-jensen/maas/uefi-arm64.
>