Merge lp://staging/~newell-jensen/maas/fix-1687487 into lp://staging/~maas-committers/maas/trunk

Proposed by Newell Jensen
Status: Merged
Approved by: Blake Rouse
Approved revision: no longer in the source branch.
Merged at revision: 6039
Proposed branch: lp://staging/~newell-jensen/maas/fix-1687487
Merge into: lp://staging/~maas-committers/maas/trunk
Diff against target: 23 lines (+5/-2)
1 file modified
src/maasserver/models/bmc.py (+5/-2)
To merge this branch: bzr merge lp://staging/~newell-jensen/maas/fix-1687487
Reviewer Review Type Date Requested Status
Lee Trager (community) Approve
Review via email: mp+323643@code.staging.launchpad.net

Commit message

Change hostname uniqueness check to use Node instead of Machine so that region, racks, etc. are checked for a potential conflicting hostname when adding a Pod.

To post a comment you must log in.
Revision history for this message
Newell Jensen (newell-jensen) wrote :

Unit tests for this are already checking against a Node object!

Revision history for this message
Lee Trager (ltrager) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.