Merge lp://staging/~newell-jensen/maas/fix-1608555-1631079 into lp://staging/~maas-committers/maas/trunk

Proposed by Newell Jensen
Status: Merged
Approved by: Newell Jensen
Approved revision: no longer in the source branch.
Merged at revision: 5468
Proposed branch: lp://staging/~newell-jensen/maas/fix-1608555-1631079
Merge into: lp://staging/~maas-committers/maas/trunk
Diff against target: 273 lines (+186/-6)
5 files modified
src/maasserver/static/js/angular/controllers/subnet_details.js (+0/-2)
src/maasserver/static/js/angular/controllers/tests/test_subnet_details.js (+0/-4)
src/maasserver/triggers/tests/test_websocket.py (+3/-0)
src/maasserver/triggers/tests/test_websocket_listener.py (+122/-0)
src/maasserver/triggers/websocket.py (+61/-0)
To merge this branch: bzr merge lp://staging/~newell-jensen/maas/fix-1608555-1631079
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+307983@code.staging.launchpad.net

Commit message

Add triggers for updating a subnet when it's IP range is created/updated/deleted.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good. But you are missing the triggers tests that should be added in triggers/tests/test_websocket_listener.py.

review: Needs Fixing
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good. Thanks for the tests.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.