MAAS

Merge ~newell-jensen/maas:lp1788756 into maas:master

  1. Git
  2. lp:~newell-jensen/maas
  3. lp1788756
  4. Merge into master
Proposed by Newell Jensen
Status: Merged
Approved by: Newell Jensen
Approved revision: 19d0b693523255c2702859ba62c24269acfdd933
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~newell-jensen/maas:lp1788756
Merge into: maas:master
Diff against target: 236 lines (+54/-26)
2 files modified
src/provisioningserver/drivers/pod/tests/test_virsh.py (+40/-15)
src/provisioningserver/drivers/pod/virsh.py (+14/-11)
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
MAAS Lander Approve
Review via email: mp+353741@code.staging.launchpad.net

Commit message

LP: #1788756 -- Only raise no network error for network attached or non-specified interfaces.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1788756 lp:~newell-jensen/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 19d0b693523255c2702859ba62c24269acfdd933

review: Approve
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks good; one question inline below that I won't block you on. (I think the same issue happens in the block devices loop, too.)

review: Approve
Revision history for this message
Newell Jensen (newell-jensen) wrote :

> Looks good; one question inline below that I won't block you on. (I think the
> same issue happens in the block devices loop, too.)

All the block devices are created first (see top part of the create_domain method in provisioningserver.drivers.pod.virsh.py) and then attached after the domain has been defined within virsh. Good question though.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches