Merge ~netplan-developers/netplan/+git/netplan-lp:cyphermox/stp into ~netplan-developers/netplan/+git/netplan-lp:master
Proposed by
Mathieu Trudel-Lapierre
| Status: | Merged |
|---|---|
| Merged at revision: | 1ed0a3c7aeeb4a2ed7bd32f44c3cc6431348b26d |
| Proposed branch: | ~netplan-developers/netplan/+git/netplan-lp:cyphermox/stp |
| Merge into: | ~netplan-developers/netplan/+git/netplan-lp:master |
| Diff against target: |
281 lines (+94/-30) 7 files modified
doc/netplan.md (+5/-0) src/networkd.c (+16/-14) src/nm.c (+16/-14) src/parse.c (+10/-1) src/parse.h (+3/-0) tests/generate.py (+5/-1) tests/integration.py (+39/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tiago Stürmer Daitx (community) | code review | Approve | |
|
Review via email:
|
|||
Description of the change
Add STP support for bridges. This is part of the typical set of features for parameterizing bridge configurations, but was forgotten while adding the possiblity of setting the other parameters.
To post a comment you must log in.
Revision history for this message
| Tiago Stürmer Daitx (tdaitx) wrote | # |
review:
Approve
(code review)
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
custom bridging felt like a separated feature, but as it prevents writing a bridge section just because STP is being defined by default I'm good with that.