Merge lp://staging/~nerd65536/byobu/trunk into lp://staging/byobu

Proposed by Simon Elmir
Status: Merged
Merge reported by: Dustin Kirkland 
Merged at revision: not available
Proposed branch: lp://staging/~nerd65536/byobu/trunk
Merge into: lp://staging/byobu
Diff against target: 12 lines (+1/-1)
1 file modified
usr/share/byobu/profiles/bashrc (+1/-1)
To merge this branch: bzr merge lp://staging/~nerd65536/byobu/trunk
Reviewer Review Type Date Requested Status
Dustin Kirkland  Approve
Review via email: mp+357122@code.staging.launchpad.net

Commit message

Add missing escape to non-Ubuntu PS1

Description of the change

usr/share/byobu/profiles/bashrc's PS1 for non-Ubuntu systems is missing a \[ near the end of the prompt

All non-printed characters, like color codes, should be wrapped in \[...\] so the length of the prompt can be calculated properly. Without the wrapping, things like scrolling back and forth through history will appear glitchy.

This commit adds the missing \[.

To post a comment you must log in.
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Great catch, thanks! This is merged and committed and will be released in 5.128.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches