Merge lp://staging/~negronjl/charm-tools/charm-tools-proof-multiple-maintainer into lp://staging/~charmers/charm-tools/trunk
Proposed by
Juan L. Negron
| Status: | Merged |
|---|---|
| Merged at revision: | 152 |
| Proposed branch: | lp://staging/~negronjl/charm-tools/charm-tools-proof-multiple-maintainer |
| Merge into: | lp://staging/~charmers/charm-tools/trunk |
| Diff against target: |
25 lines (+11/-4) 1 file modified
scripts/proof (+11/-4) |
| To merge this branch: | bzr merge lp://staging/~negronjl/charm-tools/charm-tools-proof-multiple-maintainer |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Clint Byrum (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Modified proof to accept multiple maintainers by using a yaml list.
ie: maintainer: [Juan Negron <email address hidden>, Tom Haddon <email address hidden>]
To post a comment you must log in.
Revision history for this message
| Juan L. Negron (negronjl) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hey Juan. Great quick turn around.
I dislike copy/paste code, so I'd prefer that the check only be coded once. One way to do that without needing a function is just to do this:
if type(charm[
maintainers = charm['maintainer']
else:
maintainers = [charm[
And then just iterate over maintainers. Otherwise the check can just be moved into an inline function.