Merge lp://staging/~nataliabidart/ubuntuone-control-panel/explore-folder into lp://staging/ubuntuone-control-panel
Proposed by
Natalia Bidart
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Natalia Bidart | ||||||||
Approved revision: | 171 | ||||||||
Merged at revision: | 170 | ||||||||
Proposed branch: | lp://staging/~nataliabidart/ubuntuone-control-panel/explore-folder | ||||||||
Merge into: | lp://staging/ubuntuone-control-panel | ||||||||
Diff against target: |
331 lines (+83/-51) 6 files modified
data/qt/folders.ui (+7/-2) ubuntuone/controlpanel/backend.py (+9/-8) ubuntuone/controlpanel/gui/__init__.py (+1/-0) ubuntuone/controlpanel/gui/qt/folders.py (+26/-23) ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+19/-11) ubuntuone/controlpanel/tests/test_backend.py (+21/-7) |
||||||||
To merge this branch: | bzr merge lp://staging/~nataliabidart/ubuntuone-control-panel/explore-folder | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Manuel de la Peña (community) | Approve | ||
Eric Casteleijn (community) | Approve | ||
Review via email: mp+65697@code.staging.launchpad.net |
To post a comment you must log in.
Works, and code looks great.
To me it's not clear that the tiny folder icons are buttons, however, and what they would do when clicked. Perhaps a text button would be clearer.
When clicking on the buttons it becomes apparent that they are much wider than they need to be which looks weird (because the whole button temporarily lights up/becomes selected.) If we're sticking with these icons, I would make the column they are in much narrower.
Also the "Hello Eric Casteleijn!" I do not like. I'd probably change it to something like "User: Eric Casteleijn".
These may be design decisions that have to be fixed elsewhere.