Merge lp://staging/~nataliabidart/ubuntuone-client/fix-807235 into lp://staging/ubuntuone-client

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 1047
Merged at revision: 1047
Proposed branch: lp://staging/~nataliabidart/ubuntuone-client/fix-807235
Merge into: lp://staging/ubuntuone-client
Diff against target: 466 lines (+92/-143)
8 files modified
tests/platform/linux/test_vm.py (+1/-26)
tests/platform/windows/test_vm_helper.py (+3/-26)
tests/syncdaemon/test_vm.py (+44/-17)
ubuntuone/platform/linux/__init__.py (+0/-1)
ubuntuone/platform/linux/vm_helper.py (+0/-32)
ubuntuone/platform/windows/__init__.py (+0/-1)
ubuntuone/platform/windows/vm_helper.py (+1/-32)
ubuntuone/syncdaemon/volume_manager.py (+43/-8)
To merge this branch: bzr merge lp://staging/~nataliabidart/ubuntuone-client/fix-807235
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Roberto Alsina (community) code review only Approve
Review via email: mp+67320@code.staging.launchpad.net

Commit message

- Renamed 'get_share_path' to 'get_share_dir_name' and unified the implementation between the platforms (LP: #807235).

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve (code review only)
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches