lp://staging/~nataliabidart/ubuntuone-client/dont-use-shutil-move

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/ubuntuone-client at revision 1107

Alejandro J. Cura (community): Approve on 2011-08-16

Roberto Alsina (community): Approve on 2011-08-16

Diff: 1396 lines (+462/-113)

13 files modified

bin/ubuntuone-syncdaemon (+2/-2)
tests/platform/linux/test_os_helper.py (+5/-35)
tests/platform/test_os_helper.py (+227/-11)
tests/platform/windows/test_os_helper.py (+35/-9)
tests/syncdaemon/test_fsm.py (+22/-4)
tests/syncdaemon/test_localrescan.py (+8/-9)
ubuntuone/platform/linux/__init__.py (+3/-0)
ubuntuone/platform/linux/os_helper.py (+35/-1)
ubuntuone/platform/windows/__init__.py (+3/-0)
ubuntuone/platform/windows/os_helper.py (+92/-16)
ubuntuone/syncdaemon/file_shelf.py (+2/-1)
ubuntuone/syncdaemon/filesystem_manager.py (+16/-15)
ubuntuone/syncdaemon/volume_manager.py (+12/-10)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #747741: 'move_to_trash' needs to be implemented in the Windows part	High	Fix Released
Bug #802498: Error when doing a partial commit on windows	High	Fix Released

Link a bug report

Related blueprints

1175. By Natalia Bidart on 2011-08-15

Test iomprovements.

1174. By Natalia Bidart on 2011-08-15

- Implementing a multiplatform version of recursive move so commits of partial
files does not fail (LP: #802498).

- Skipped in windows some tests in test_fsm since we're not doing metadata
migration in that OS.

- Replaced all calls to shutil.move, shutil.rmtree and os.walk by multiplaform
methods.

1173. By Manuel de la Peña on 2011-08-12

Update docs.

1172. By Manuel de la Peña on 2011-08-12

Remove useless extra method.

1171. By Manuel de la Peña on 2011-08-12

Fix typo.

1170. By Manuel de la Peña on 2011-06-25

Patch the correct module.

1169. By Manuel de la Peña on 2011-08-12

Fixed the cleanup.

1168. By Manuel de la Peña on 2011-06-25

Ensured that the tests do inherit from the common ones.

1167. By Manuel de la Peña on 2011-08-12

Added tests for the walk method.

1166. By Manuel de la Peña on 2011-08-12

Remove duplicate import and extra line.