Merge lp://staging/~nataliabidart/ubuntu-sso-client/split-gui into lp://staging/ubuntu-sso-client
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Natalia Bidart | ||||||||
| Approved revision: | 657 | ||||||||
| Merged at revision: | 653 | ||||||||
| Proposed branch: | lp://staging/~nataliabidart/ubuntu-sso-client/split-gui | ||||||||
| Merge into: | lp://staging/ubuntu-sso-client | ||||||||
| Diff against target: |
1130 lines (+329/-227) 14 files modified
.bzrignore (+1/-0) data/ui.glade (+148/-101) po/POTFILES.in (+1/-1) setup.py (+2/-3) ubuntu_sso/credentials.py (+11/-11) ubuntu_sso/gtk/__init__.py (+19/-0) ubuntu_sso/gtk/gui.py (+13/-19) ubuntu_sso/gtk/tests/__init__.py (+19/-0) ubuntu_sso/gtk/tests/test_gui.py (+12/-13) ubuntu_sso/main.py (+6/-3) ubuntu_sso/tests/__init__.py (+2/-0) ubuntu_sso/tests/bin/show_gui (+1/-1) ubuntu_sso/tests/test_credentials.py (+89/-73) ubuntu_sso/tests/test_main.py (+5/-2) |
||||||||
| To merge this branch: | bzr merge lp://staging/~nataliabidart/ubuntu-sso-client/split-gui | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Vincenzo Di Somma (community) | Approve | ||
| Eric Casteleijn (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch introduces 2 main changes:
** The gtk ui has been tweaked a bit so it looks good even on small screens or with big fonts
To test this you can follow the procedure described in the bug report LP: #627496.
** All the gtk ui code is separated into a new gtk package
To accomplish the former, besides moving modules around, 2 new parameters were added to the (new since Natty) dbus methods for the CredentialsMana
* 'ui_module': string describing the import path to the module providing the UI
* 'ui_class': string describing the name of the class within 'ui_module' that opens the graphical interface to login/register
To test this new parameters you should:
* run from this branch the following:
nessita@
* open d-feet and execute the 'login' or 'register' method for the CredentialsMana
'Test Me', {'help_text': 'Lorem Ipsum sir Amet', 'tc_url': 'http://
this would throw ImportError such as:
Traceback (most recent call last):
File "/home/
result = f(self, *a, **kw)
File "/home/
__import_
ImportError: No module named me
A successful call would be achieved passing parameters like:
'Test Me', {'help_text': 'Lorem Ipsum sir Amet', 'tc_url': 'http://
| Eric Casteleijn (thisfred) wrote | # |
| Vincenzo Di Somma (vds) | # |
| Ubuntu One Auto Pilot (otto-pilot) wrote | # |
"""
* open d-feet and execute the 'login' or 'register' method for the CredentialsMana
'Test Me', {'help_text': 'Lorem Ipsum sir Amet', 'tc_url': 'http://
this would throw ImportError such as:
...
"""
It does not, I see:
'This method did not return anything' for both login and register.
I'm probably doing it wrong™.