Merge lp://staging/~nataliabidart/ubuntu-sso-client/fix-100pct-links-stable into lp://staging/ubuntu-sso-client/stable-1-0

Proposed by Natalia Bidart
Status: Merged
Approved by: Vincenzo Di Somma
Approved revision: 633
Merged at revision: 633
Proposed branch: lp://staging/~nataliabidart/ubuntu-sso-client/fix-100pct-links-stable
Merge into: lp://staging/ubuntu-sso-client/stable-1-0
Diff against target: 48 lines (+9/-17)
1 file modified
bin/ubuntu-sso-login (+9/-17)
To merge this branch: bzr merge lp://staging/~nataliabidart/ubuntu-sso-client/fix-100pct-links-stable
Reviewer Review Type Date Requested Status
Vincenzo Di Somma (community) Approve
John Lenton (community) Approve
Review via email: mp+38210@code.staging.launchpad.net

Commit message

Replace twisted gtk reactor with the standard gtk mainloop. (LP: #655327).

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

I don't know if this deserves a badge for finding the issue, or a scoop of icecream to the forehead for putting in there in the first place...

good job we fixed it, either way :)

review: Approve
Revision history for this message
Vincenzo Di Somma (vds) wrote :

Tests pass, code looks ok!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches