Merge lp://staging/~nataliabidart/software-center/the-organizer into lp://staging/software-center
Proposed by
Natalia Bidart
| Status: | Merged |
|---|---|
| Merged at revision: | 3030 |
| Proposed branch: | lp://staging/~nataliabidart/software-center/the-organizer |
| Merge into: | lp://staging/software-center |
| Diff against target: |
8189 lines (+2221/-2700) 102 files modified
gen-coverage-report.sh (+13/-7) run-tests.sh (+70/-29) softwarecenter/log.py (+12/-10) softwarecenter/ui/gtk3/dialogs/dependency_dialogs.py (+1/-36) softwarecenter/ui/gtk3/panes/availablepane.py (+0/-47) softwarecenter/ui/gtk3/panes/globalpane.py (+0/-31) softwarecenter/ui/gtk3/panes/historypane.py (+2/-34) softwarecenter/ui/gtk3/panes/installedpane.py (+0/-43) softwarecenter/ui/gtk3/panes/pendingpane.py (+0/-27) softwarecenter/ui/gtk3/panes/viewswitcher.py (+0/-38) softwarecenter/ui/gtk3/review_gui_helper.py (+4/-0) softwarecenter/ui/gtk3/views/appdetailsview.py (+0/-73) softwarecenter/ui/gtk3/views/appview.py (+0/-97) softwarecenter/ui/gtk3/views/catview_gtk.py (+0/-108) softwarecenter/ui/gtk3/views/pkgnamesview.py (+0/-39) softwarecenter/ui/gtk3/views/purchaseview.py (+0/-43) softwarecenter/ui/gtk3/widgets/apptreeview.py (+0/-56) softwarecenter/ui/gtk3/widgets/backforward.py (+0/-17) softwarecenter/ui/gtk3/widgets/buttons.py (+0/-40) softwarecenter/ui/gtk3/widgets/containers.py (+0/-27) softwarecenter/ui/gtk3/widgets/description.py (+0/-262) softwarecenter/ui/gtk3/widgets/exhibits.py (+0/-43) softwarecenter/ui/gtk3/widgets/labels.py (+0/-23) softwarecenter/ui/gtk3/widgets/oneconfviews.py (+0/-36) softwarecenter/ui/gtk3/widgets/recommendations.py (+0/-45) softwarecenter/ui/gtk3/widgets/reviews.py (+0/-43) softwarecenter/ui/gtk3/widgets/searchentry.py (+0/-22) softwarecenter/ui/gtk3/widgets/spinner.py (+0/-19) softwarecenter/ui/gtk3/widgets/stars.py (+0/-54) softwarecenter/ui/gtk3/widgets/symbolic_icons.py (+0/-25) softwarecenter/ui/gtk3/widgets/thumbnail.py (+0/-79) softwarecenter/ui/gtk3/widgets/videoplayer.py (+0/-48) test/gen-coverage-for-single-test.sh (+0/-4) tests/channel_query.py (+1/-5) tests/disabled_test_gnomekeyring.py (+4/-8) tests/gtk3/test_app.py (+1/-3) tests/gtk3/test_app_view.py (+14/-23) tests/gtk3/test_appdetailsview.py (+76/-156) tests/gtk3/test_appmanager.py (+9/-8) tests/gtk3/test_appstore2.py (+11/-14) tests/gtk3/test_catview.py (+31/-33) tests/gtk3/test_custom_lists.py (+15/-33) tests/gtk3/test_debfile_view.py (+5/-3) tests/gtk3/test_dialogs.py (+10/-13) tests/gtk3/test_globalpane.py (+8/-6) tests/gtk3/test_install_progress.py (+11/-23) tests/gtk3/test_installedpane.py (+14/-24) tests/gtk3/test_navhistory.py (+2/-5) tests/gtk3/test_panes.py (+17/-33) tests/gtk3/test_purchase.py (+39/-40) tests/gtk3/test_recommendations_widgets.py (+10/-24) tests/gtk3/test_reviews.py (+22/-26) tests/gtk3/test_search.py (+16/-30) tests/gtk3/test_spinner.py (+1/-1) tests/gtk3/test_unity_launcher_integration.py (+62/-64) tests/gtk3/test_views.py (+19/-28) tests/gtk3/test_widgets.py (+48/-71) tests/gtk3/windows.py (+1163/-0) tests/qml/test_ui_qml_helpers.py (+4/-9) tests/test_addons.py (+6/-10) tests/test_aptd.py (+11/-11) tests/test_apthistory.py (+11/-20) tests/test_categories.py (+16/-17) tests/test_channels.py (+6/-7) tests/test_cmdfiner.py (+4/-5) tests/test_database.py (+68/-61) tests/test_debfileapplication.py (+14/-13) tests/test_description_norm.py (+5/-9) tests/test_distro.py (+4/-6) tests/test_downloader.py (+8/-17) tests/test_enquire.py (+8/-14) tests/test_gwibber.py (+36/-20) tests/test_htmlize.py (+3/-5) tests/test_hw.py (+7/-8) tests/test_i18n.py (+6/-9) tests/test_launchpad.py (+7/-13) tests/test_logging.py (+33/-22) tests/test_login_backend.py (+3/-5) tests/test_mime.py (+11/-8) tests/test_netstatus.py (+4/-6) tests/test_origin.py (+9/-8) tests/test_package_info.py (+4/-5) tests/test_pep8.py (+5/-1) tests/test_pkginfo.py (+8/-10) tests/test_plugin.py (+10/-12) tests/test_ppa_iconfilename.py (+7/-6) tests/test_purchase_backend.py (+11/-13) tests/test_pyflakes.py (+1/-5) tests/test_recagent.py (+28/-34) tests/test_region.py (+4/-6) tests/test_reinstall_purchased.py (+6/-6) tests/test_rnr_api.py (+4/-5) tests/test_scagent.py (+8/-9) tests/test_spawn_helper.py (+5/-5) tests/test_startup.py (+4/-4) tests/test_testutils.py (+6/-7) tests/test_ubuntu_sso_api.py (+3/-5) tests/test_utils.py (+38/-35) tests/test_where_is_it.py (+17/-16) tests/test_xapian.py (+7/-7) tests/test_xapian_query.py (+3/-3) tests/utils.py (+47/-24) |
| To merge this branch: | bzr merge lp://staging/~nataliabidart/software-center/the-organizer |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Tests cleanup:
- Renamed test/ dir to tests/.
- Moved the testutils module to tests/utils.py.
- Removed all unnecessary logging setup per test file.
- Removed all unnecessary shebangs in test files.
- Isolated test code into tests/ directory, including moving all the
get_
tests/
- Removed all the calls to Gtk.main() in gtk3 tests since that blocks the
execution of the suite.
- Pep8 and pyflakes fixes in the files already modified in this branch.
- Minor bug fix in the softwarecenter/
log dir with proper perms.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks and sorry that the review took so long.
This is a great cleanup! I really like tests/windows.py and the examples how to create the
interactive test windows. This should probably get a small README.debug file so that its
easy to find this really useful helper.