Merge lp://staging/~nataliabidart/software-center/fix-977931 into lp://staging/software-center/5.2
Proposed by
Natalia Bidart
| Status: | Merged |
|---|---|
| Merged at revision: | 3027 |
| Proposed branch: | lp://staging/~nataliabidart/software-center/fix-977931 |
| Merge into: | lp://staging/software-center/5.2 |
| Diff against target: |
1180 lines (+627/-146) 19 files modified
README (+1/-0) softwarecenter/backend/spawn_helper.py (+3/-0) softwarecenter/db/__init__.py (+7/-2) softwarecenter/db/database.py (+4/-0) softwarecenter/db/debfile.py (+38/-21) softwarecenter/enums.py (+6/-0) softwarecenter/testutils.py (+11/-1) softwarecenter/ui/gtk3/SimpleGtkbuilderApp.py (+2/-1) softwarecenter/ui/gtk3/app.py (+151/-89) softwarecenter/ui/gtk3/models/appstore2.py (+1/-0) softwarecenter/ui/gtk3/session/appmanager.py (+5/-0) softwarecenter/ui/gtk3/session/viewmanager.py (+5/-0) softwarecenter/ui/gtk3/views/appdetailsview.py (+2/-2) softwarecenter/ui/gtk3/widgets/videoplayer.py (+5/-1) test/gtk3/test_app.py (+357/-0) test/gtk3/test_debfile_view.py (+3/-8) test/gtk3/test_purchase.py (+8/-12) test/test_database.py (+8/-3) test/test_debfileapplication.py (+10/-6) |
| To merge this branch: | bzr merge lp://staging/~nataliabidart/software-center/fix-977931 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-04-17.
Commit message
- Unified package string parsing into a single method that will be used from either the command line arguments, or from the dbus method 'bringToFront'. This way, search will be consistent between all entry points.
- Also added proper test suites for the above.
To post a comment you must log in.
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Revision history for this message
| Natalia Bidart (nataliabidart) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks Natalia for this branch and sorry for my slow reply.
First let me say thanks for the work and the refactor and the excellent test, we shall use that
as a example.
This looks fine, there have been some changes in the 5.2 branch so I merged it and resolved
conflicts and tweaked it a bit more, please remerge lp:~mvo/software-center/fix-977931/ with this branch
and let me know what you think.
I was curious how to reproduce/
be "None". I revert that change but for me its not crashing so I wonder if that is still needed? Or is it
a random issue? Except for this (which I just would like to understand better how it happens) the branch
is +10 approve ;)
Additional thanks for unifying get_mock_options() and the with open() fix (and the cleanup) in test_database.py.