Merge lp://staging/~nataliabidart/software-center/cant-stop-the-music into lp://staging/software-center/5.2

Thanks Natalia, this is great work!

There is one small issue:
- navigate to "plutoids"
- click on "back"
- click on "forward"
- the video frame is now blank because on navigation to the page the url is not updated
  (as the view is "clever" and remembers that it does not need to reload the page)

It would be great if you could have a look at this.

Another thought for trunk would be to decouple the "stop" from the ViewManager.display_page and add
signals or functions like "enter-page", "leave-page" so that the page itself can do the magic that needs
to be done (like stop video or store the vadjustment in the applist). What do you think about
this?

(oh, and I love your branch names)

> Thanks Natalia, this is great work!
>
> There is one small issue:
> - navigate to "plutoids"
> - click on "back"
> - click on "forward"
> - the video frame is now blank because on navigation to the page the url is
> not updated
> (as the view is "clever" and remembers that it does not need to reload the
> page)
>
> It would be great if you could have a look at this.

Nice catch! Will be fixing this ASAP.

> Another thought for trunk would be to decouple the "stop" from the
> ViewManager.display_page and add
> signals or functions like "enter-page", "leave-page" so that the page itself
> can do the magic that needs
> to be done (like stop video or store the vadjustment in the applist). What do
> you think about
> this?

I would love that considering that the current proposed solution couples the different modules too much.

You want me to propose a branch against trunk? is it ok if trunk and 5.2 start diverging?

On Mon, Jun 18, 2012 at 11:51:34AM -0000, Natalia Bidart wrote:
> > Thanks Natalia, this is great work!
> >
> > There is one small issue:
> > - navigate to "plutoids"
> > - click on "back"
> > - click on "forward"
> > - the video frame is now blank because on navigation to the page the url is
> > not updated
> > (as the view is "clever" and remembers that it does not need to reload the
> > page)
> >
> > It would be great if you could have a look at this.
>
> Nice catch! Will be fixing this ASAP.
Thanks!

> > Another thought for trunk would be to decouple the "stop" from the
> > ViewManager.display_page and add
> > signals or functions like "enter-page", "leave-page" so that the page itself
> > can do the magic that needs
> > to be done (like stop video or store the vadjustment in the applist). What do
> > you think about
> > this?
>
> I would love that considering that the current proposed solution couples the different modules too much.
>
> You want me to propose a branch against trunk? is it ok if trunk and 5.2 start diverging?

I think for 5.2 this branch is perfect as it makes the SRU upload
easier (small amount of code changes etc). For the improved fix we
should target trunk and I think its ok if the two branches diverge,
its a unavoidable in the longer term anyway :)

Cheers,
 Michael

Thanks for the fix, this looks fine now. Plus I appreciate the cleanup in the test, e.g. the new
 "set_mock_app_and_details()"