Merge ~nansari/django-piston:fix-for-SN-1445 into django-piston:master
Proposed by
Najam Ahmed Ansari
| Status: | Merged |
|---|---|
| Approved by: | Najam Ahmed Ansari |
| Approved revision: | 32fbb4a8707d9da68f2ae9cd660b1dcd0a716bf0 |
| Merge reported by: | Otto Co-Pilot |
| Merged at revision: | not available |
| Proposed branch: | ~nansari/django-piston:fix-for-SN-1445 |
| Merge into: | django-piston:master |
| Diff against target: |
55 lines (+8/-17) 2 files modified
piston/tests.py (+3/-0) piston/utils.py (+5/-17) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Przemysław Suliga | Approve | ||
|
Review via email:
|
|||
Commit message
Removing piston's custom HttpResponseWrapper
Description of the change
The wrapper class was attempting to work around a bug in Django which has since
been fixed, rendering the wrapper unnecessary. Removing the wrapper also fixes
SN-1445.
To post a comment you must log in.
Revision history for this message
| Przemysław Suliga (suligap) wrote | # |
Revision history for this message
| Najam Ahmed Ansari (nansari) wrote | # |
Revision history for this message
| Przemysław Suliga (suligap) | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The extra json.dumps() additions you added to tests made me wonder. And I think something like
https:/
might be the way to go after all. That wrapper has an original function beyond working around an old django bug. But we can make it use django's auto encoding when needed (as in my diff).
See also a testing comment.