Merge lp://staging/~naaando/wingpanel-indicator-network/vpn into lp://staging/~wingpanel-devs/wingpanel-indicator-network/trunk
Proposed by
Fernando da Silva Sousa
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Danielle Foré | ||||
| Approved revision: | 230 | ||||
| Merged at revision: | 233 | ||||
| Proposed branch: | lp://staging/~naaando/wingpanel-indicator-network/vpn | ||||
| Merge into: | lp://staging/~wingpanel-devs/wingpanel-indicator-network/trunk | ||||
| Diff against target: |
860 lines (+619/-171) 6 files modified
src/CMakeLists.txt (+3/-0) src/Widgets/PopoverWidget.vala (+7/-0) src/Widgets/VpnInterface.vala (+96/-0) src/common/Widgets/AbstractVpnInterface.vala (+206/-0) src/common/Widgets/NMVisualizer.vala (+176/-171) src/common/Widgets/VpnMenuItem.vala (+131/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~naaando/wingpanel-indicator-network/vpn | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Adam Bieńkowski (community) | code | Approve | |
| Danielle Foré | ux | Approve | |
| Kirill Romanov (community) | test | Approve | |
|
Review via email:
|
|||
Commit message
Show configured VPNs
Description of the change
Adds VPN menu
To post a comment you must log in.
Revision history for this message
| Fernando da Silva Sousa (naaando) wrote | # |
Revision history for this message
| Danielle Foré (danrabbit) wrote | # |
Revision history for this message
| Kirill Romanov (djaler1) wrote | # |
Revision history for this message
| Danielle Foré (danrabbit) | # |
review:
Approve
(ux)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I don't have any VPN connections set up, but I still get the header in the menu. It should probably only show if you actually have VPN connections configured. Especially since toggling VPN to on does nothing. This is kind of dangerous honestly because it could make people think they have a VPN just by hitting this switch.
It also shows as "Vpn" instead of "VPN"