Unity 8

Merge lp://staging/~mzanetti/unity8/windowed-by-kbd-only into lp://staging/unity8

windowed-by-kbd-only
Merge into trunk

Proposed by Michael Zanetti on 2016-01-26

Status:

Merged

Approved by:

Michał Sawicz on 2016-01-29

Approved revision:

2139

Merged at revision:

2156

Proposed branch:

lp://staging/~mzanetti/unity8/windowed-by-kbd-only

Merge into:

lp://staging/unity8

Prerequisite:

lp://staging/~dandrader/unity8/dontRotateDesktop-lp1515977

Diff against target:

111 lines (+54/-29)

2 files modified

qml/OrientedShell.qml (+11/-4)
tests/qmltests/tst_OrientedShell.qml (+43/-25)

To merge this branch:

bzr merge lp://staging/~mzanetti/unity8/windowed-by-kbd-only

Related bugs:

Bug #1531270: Shell always switches to Windowed mode when mouse is connected	High	Fix Released
Bug #1535399: Need screen size thresholds for switching to windowed automatically	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michał Sawicz	code	2016-01-26	Approve on 2016-01-29
Unity8 CI Bot	continuous-integration	2016-01-26	Needs Fixing on 2016-01-28
PS Jenkins bot (community)	continuous-integration	2016-01-26	Needs Fixing on 2016-01-28
Review via email: mp+284011@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-01-20.

Commit message

Make big tablets switch to windowed mode by plugging a kbd only

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.

nope

* Did you perform an exploratory manual test run of your code change and any related functionality?

yes

* Did you make sure that your branch does not contain spurious tags?

yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

nope

* If you changed the UI, has there been a design review?

nope

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-21: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:2137
http://jenkins.qa.ubuntu.com/job/unity8-ci/7118/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6105
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/533/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1823
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/526
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1718
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1718
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/525
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/524
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4713
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6116
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6116/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26856
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/270/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/531
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/531/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26855

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7118/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-21: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:2137
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/160/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/160/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) on 2016-01-26: Posted in a previous version of this proposal

#

review: Needs Information

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-26: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:2138
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/206/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/206/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-26:

#

FAILED: Continuous integration, rev:2138
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/207/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/207/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-26:

#

FAILED: Continuous integration, rev:2138
http://jenkins.qa.ubuntu.com/job/unity8-ci/7158/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6209
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/573/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1863
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/566
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1758
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1758
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/565
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/564
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4787
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6220
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6220/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27058
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/296/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/571
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/571/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27057

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7158/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~mzanetti/unity8/windowed-by-kbd-only updated on 2016-01-27

2139. By Michael Zanetti on 2016-01-27: drop debug prints

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-28:

#

FAILED: Continuous integration, rev:2139
http://jenkins.qa.ubuntu.com/job/unity8-ci/7165/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6233
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/580/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1870
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/573
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1765
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1765
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/572
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/571
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4802
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6244
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6244/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27105
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/299/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/578
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/578/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27104

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7165/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2016-01-28:

#

FAILED: Continuous integration, rev:2139
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/215/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/215/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2016-01-29:

#

* Did you perform an exploratory manual test run of the code change and any related functionality?
Cimi's testing the silo

* Did CI run pass? If not, please explain why.
Only failures fixed in other branches

* Did you make sure that the branch does not contain spurious tags?
T

review: Approve (code)

Revision history for this message

Michał Sawicz (saviq) wrote on 2016-01-29:

#

Approving per cimi's silo testing.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Michael Zanetti

Mohammad Rakibul Hasan

Unity Team