Merge lp://staging/~mzanetti/unity8/sim-pin-darkening into lp://staging/unity8
Proposed by
Michael Zanetti
| Status: | Merged |
|---|---|
| Approved by: | Lukáš Tinkl |
| Approved revision: | 2376 |
| Merged at revision: | 2405 |
| Proposed branch: | lp://staging/~mzanetti/unity8/sim-pin-darkening |
| Merge into: | lp://staging/unity8 |
| Diff against target: |
11 lines (+1/-0) 1 file modified
qml/Notifications/NotificationMenuItemFactory.qml (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~mzanetti/unity8/sim-pin-darkening |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Lukáš Tinkl (community) | Approve | ||
|
Review via email:
|
|||
Commit message
fix the SIM PIN darkening after it got removed accidentally
Description of the change
* no related branches
* tested on turbo
* no design or package review needed
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Yup, it fixes the linked bug, thanks for the patch, it was an oversight from me
* Did you perform an exploratory manual test run of the code change and any related functionality?
yes
* Did CI run pass? If not, please explain why.
not yet, it should :)