Merge lp://staging/~mzanetti/unity8/rotate-dash into lp://staging/unity8
Proposed by
Michael Zanetti
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Michael Zanetti | ||||||||
| Approved revision: | 2334 | ||||||||
| Merged at revision: | 2365 | ||||||||
| Proposed branch: | lp://staging/~mzanetti/unity8/rotate-dash | ||||||||
| Merge into: | lp://staging/unity8 | ||||||||
| Diff against target: |
8 lines (+0/-1) 1 file modified
data/unity8-dash.desktop.in (+0/-1) |
||||||||
| To merge this branch: | bzr merge lp://staging/~mzanetti/unity8/rotate-dash | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel d'Andrada (community) | Needs Fixing | ||
| Lukáš Tinkl (community) | Approve | ||
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Drop the rotation lock for the dash
Description of the change
Everyone thinks it's a bug and it really should rotate. Design agrees but there is no point in waiting for the next dash rework spec to be finalized just to enable this. I've had it enabled for a while on my device and it seems to behave well.
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* Did you make sure that your branch does not contain spurious tags?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
no
* If you changed the UI, has there been a design review?
Yes, Paty acked it.
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
Revision history for this message
| Michael Zanetti (mzanetti) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:2334
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/