Unity 8

Merge lp://staging/~mzanetti/unity8/reversible-spread into lp://staging/unity8

reversible-spread
Merge into trunk

Proposed by Michael Zanetti on 2014-11-10

Status:

Merged

Approved by:

Michał Sawicz on 2014-12-02

Approved revision:

1439

Merged at revision:

1469

Proposed branch:

lp://staging/~mzanetti/unity8/reversible-spread

Merge into:

lp://staging/unity8

Diff against target:

233 lines (+31/-51)

4 files modified

qml/Stages/PhoneStage.qml (+17/-33)
qml/Stages/TabletStage.qml (+5/-14)
tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py (+1/-1)
tests/qmltests/Stages/tst_PhoneStage.qml (+8/-3)

To merge this branch:

bzr merge lp://staging/~mzanetti/unity8/reversible-spread

Related bugs:

Bug #1355284: Switching swipe directions should reverse app spread	High	Fix Released
Bug #1368668: [Apps switcher] Visual feedback of user's finger movement needed throughout the gesture	Medium	Fix Released
Bug #1368677: [Apps switcher] Move commit points toward right to make spread more accessible	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michał Sawicz			Approve on 2014-12-02
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-12-02
Albert Astals Cid (community)		2014-11-10	Approve on 2014-11-25
Review via email: mp+241274@code.staging.launchpad.net

Commit message

make spread reversible

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.

no

* Did you perform an exploratory manual test run of your code change and any related functionality?

yes

* Did you make sure that your branch does not contain spurious tags?

yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

* If you changed the UI, has there been a design review?

change requested by design

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-10:

#

PASSED: Continuous integration, rev:1433
http://jenkins.qa.ubuntu.com/job/unity8-ci/4867/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/89
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/85
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/89
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/89/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15627

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4867/rebuild

review: Approve (continuous-integration)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-20:

#

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

* Did CI run pass?
Yes

* Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-11-25:

#

Ok again

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-25:

#

FAILED: Continuous integration, rev:1435
http://jenkins.qa.ubuntu.com/job/unity8-ci/4971/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/348
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/148
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/136
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/136
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/317
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/348
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/348/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16234

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4971/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-25:

#

FAILED: Continuous integration, rev:1436
http://jenkins.qa.ubuntu.com/job/unity8-ci/4973/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/355
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/150
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/138
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/138
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/323
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/355
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/355/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16241

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4973/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-12-01:

#

This introduced a failure in AP:
unity8.application_lifecycle.tests.test_application_lifecycle.ApplicationLifecycleTests.test_app_moves_from_unfocused_to_focused

review: Needs Fixing

lp://staging/~mzanetti/unity8/reversible-spread updated on 2014-12-01

1437. By Michael Zanetti on 2014-12-01: fix ap test
1438. By Michael Zanetti on 2014-12-01: merge trunk, fix tests that broke with merge

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-01:

#

FAILED: Continuous integration, rev:1437
http://jenkins.qa.ubuntu.com/job/unity8-ci/4995/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/419
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/172/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/369
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/419
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/419/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16351

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4995/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-02:

#

FAILED: Continuous integration, rev:1438
http://jenkins.qa.ubuntu.com/job/unity8-ci/4998/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/430
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/175
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/163
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/163
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/378
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/430
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/430/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16366

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4998/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~mzanetti/unity8/reversible-spread updated on 2014-12-02

1439. By Michael Zanetti on 2014-12-02: try this

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-02:

#

FAILED: Continuous integration, rev:1439
http://jenkins.qa.ubuntu.com/job/unity8-ci/4999/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/438/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/176
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/164
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/164
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/384/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/438
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/438/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16383

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4999/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) on 2014-12-02:

#

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Michael Zanetti

Mohammad Rakibul Hasan

Unity Team