Merge lp://staging/~mzanetti/unity8/fix-super-hides-launcher into lp://staging/unity8
Proposed by
Michael Zanetti
| Status: | Superseded | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~mzanetti/unity8/fix-super-hides-launcher | ||||
| Merge into: | lp://staging/unity8 | ||||
| Diff against target: |
164 lines (+70/-14) 3 files modified
qml/Launcher/Launcher.qml (+2/-2) qml/Launcher/LauncherPanel.qml (+24/-6) tests/qmltests/Launcher/tst_Launcher.qml (+44/-6) |
||||
| To merge this branch: | bzr merge lp://staging/~mzanetti/unity8/fix-super-hides-launcher | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Lukáš Tinkl (community) | Approve | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2017-03-28.
Commit message
Don't hide the launcher on super press if it's locked visible
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
n/a
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Lukáš Tinkl (lukas-kde) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Tested, works correctly
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Waiting