Unity 8

Merge lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd into lp://staging/unity8

  1. fix-laggy-launcher-dnd
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Michael Terry
Approved revision: 1644
Merged at revision: 1678
Proposed branch: lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd
Merge into: lp://staging/unity8
Diff against target: 97 lines (+23/-4)
5 files modified
plugins/AccountsService/AccountsService.cpp (+1/-1)
plugins/AccountsService/AccountsServiceDBusAdaptor.cpp (+11/-2)
plugins/AccountsService/AccountsServiceDBusAdaptor.h (+2/-0)
plugins/Unity/Launcher/gsettings.cpp (+8/-1)
plugins/Unity/Launcher/gsettings.h (+1/-0)
To merge this branch: bzr merge lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd
Reviewer Review Type Date Requested Status
Michael Terry Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+251567@code.staging.launchpad.net

Commit message

performance improvements

* Prevent processing of built-in AccountsService properties if we know it's not a built-in that changed
* don't reload the launcher settings after we just set them ourselves

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

n/a

To post a comment you must log in.
lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd updated
1642. By Michael Zanetti

fix typo in comment

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1642
http://jenkins.qa.ubuntu.com/job/unity8-ci/5381/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1617
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/545
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/546
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/546
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1435
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1615
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1615/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18501

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5381/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

Inline comments

review: Needs Fixing
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Added my two cents inline

lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd updated
1643. By Michael Zanetti

be more clever with caching

Revision history for this message
Michael Zanetti (mzanetti) wrote :

inline replies

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1643
http://jenkins.qa.ubuntu.com/job/unity8-ci/5386/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1639
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/550
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/551
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/551
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1453
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1637
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1637/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18530

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5386/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd updated
1644. By Michael Zanetti

always reset the flag

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1644
http://jenkins.qa.ubuntu.com/job/unity8-ci/5389/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1646
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/553
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/554
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/554
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1460
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1644
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1644/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18549

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5389/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

Looks great! Tested and it's fine.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 Yes

 * Did CI run pass? If not, please explain why.
 Eh, for other reasons.

 * Did you make sure that the branch does not contain spurious tags?
 Yes

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote :

Is there a way to test this? The symptom I was fighting with this morning was starting or closing an unpinned app, this resulted in 1-2s UI lock every time.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> Is there a way to test this? The symptom I was fighting with this morning was
> starting or closing an unpinned app, this resulted in 1-2s UI lock every time.

So the actual issue is that AccountService does only emit a "Changed" signal for all built-in properties, without having a parameter that actually telly you which built-in property it is. That in turn causes all connected things to look up their properties with sync dbus calls.

This branch at least decouples built-in properties from not built-in ones (the launcher stuff isn't built-in) so a change in the launcher doesn't cause things like "backgroundimage" to refresh at least.

I guess it'd be possible to test if a change in a not built-in property does not emit the generic changed property. Whether that's really a useful test or not, I'm not exactly sure about.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches