Merge lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd into lp://staging/unity8
Proposed by
Michael Zanetti
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Michael Terry | ||||||||
Approved revision: | 1644 | ||||||||
Merged at revision: | 1678 | ||||||||
Proposed branch: | lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd | ||||||||
Merge into: | lp://staging/unity8 | ||||||||
Diff against target: |
97 lines (+23/-4) 5 files modified
plugins/AccountsService/AccountsService.cpp (+1/-1) plugins/AccountsService/AccountsServiceDBusAdaptor.cpp (+11/-2) plugins/AccountsService/AccountsServiceDBusAdaptor.h (+2/-0) plugins/Unity/Launcher/gsettings.cpp (+8/-1) plugins/Unity/Launcher/gsettings.h (+1/-0) |
||||||||
To merge this branch: | bzr merge lp://staging/~mzanetti/unity8/fix-laggy-launcher-dnd | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Terry | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email: mp+251567@code.staging.launchpad.net |
Commit message
performance improvements
* Prevent processing of built-in AccountsService properties if we know it's not a built-in that changed
* don't reload the launcher settings after we just set them ourselves
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* Did you make sure that your branch does not contain spurious tags?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
n/a
To post a comment you must log in.
FAILED: Continuous integration, rev:1642 jenkins. qa.ubuntu. com/job/ unity8- ci/5381/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1617 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- vivid/545 jenkins. qa.ubuntu. com/job/ unity8- vivid-amd64- ci/546 jenkins. qa.ubuntu. com/job/ unity8- vivid-i386- ci/546 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1435 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1615 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1615/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 18501
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5381/ rebuild
http://