Unity 8

Merge lp://staging/~mzanetti/unity8/earpiece-button into lp://staging/unity8

  1. earpiece-button
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Michael Terry
Approved revision: 1559
Merged at revision: 1563
Proposed branch: lp://staging/~mzanetti/unity8/earpiece-button
Merge into: lp://staging/unity8
Prerequisite: lp://staging/~mterry/unity8/no-shutdown-dialog-while-suspended
Diff against target: 26 lines (+14/-2)
1 file modified
qml/Shell.qml (+14/-2)
To merge this branch: bzr merge lp://staging/~mzanetti/unity8/earpiece-button
Reviewer Review Type Date Requested Status
Michael Terry Approve
PS Jenkins bot continuous-integration Pending
Josh Arenson Pending
Review via email: mp+247152@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-01-16.

Commit message

Add support for earpiece media buttons

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

https://code.launchpad.net/~tiagosh/telephony-service/fix-1398427/+merge/246224 is required for this to work properly.

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

n/a

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:1558
http://jenkins.qa.ubuntu.com/job/unity8-ci/5154/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/836
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/318
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/319
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/319
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/729
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/834
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/834/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17152

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5154/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Josh Arenson (josharenson) wrote : Posted in a previous version of this proposal

* Did you perform an exploratory manual test run of the code change and any related functionality?

   Tested with Apple and Samsung headphones on Mako.

 * Did CI run pass? If not, please explain why.
   No, AP issues. However qmltests pass locally.

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

Code looks fine

review: Approve
lp://staging/~mzanetti/unity8/earpiece-button updated
1560. By Michael Zanetti

merge again

Revision history for this message
Josh Arenson (josharenson) wrote :

I imagine its critical to get this merged ASAP, but I'm going to port all these changes into lp:~josharenson/unity8/physical_keys_filter for the future.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches