Merge lp://staging/~mzanetti/unity-api/dashActive into lp://staging/unity-api

Proposed by Michael Zanetti
Status: Merged
Approved by: Gerry Boland
Approved revision: 157
Merged at revision: 160
Proposed branch: lp://staging/~mzanetti/unity-api/dashActive
Merge into: lp://staging/unity-api
Diff against target: 112 lines (+36/-1)
6 files modified
debian/changelog (+6/-0)
include/unity/shell/application/ApplicationManagerInterface.h (+15/-0)
include/unity/shell/application/CMakeLists.txt (+1/-1)
test/qmltest/mocks/plugins/Unity/Application/Mocks/MockApplicationManager.cpp (+10/-0)
test/qmltest/mocks/plugins/Unity/Application/Mocks/MockApplicationManager.h (+3/-0)
test/qmltest/unity/shell/application/tst_Application.qml (+1/-0)
To merge this branch: bzr merge lp://staging/~mzanetti/unity-api/dashActive
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+235273@code.staging.launchpad.net

Commit message

add a dashActive property to the application API

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

https://code.launchpad.net/~unity-team/qtmir/fix-some-lifecycle-bugs/+merge/234087
https://code.launchpad.net/~mzanetti/unity8/async-dashcommunicator/+merge/235272

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 * Did you make sure that your branch does not contain spurious tags?
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 * If you changed the UI, has there been a design review?

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) :
review: Approve
158. By Michael Zanetti

merge trunk

159. By Michael Zanetti

dashActive -> forceDashActive

160. By Michael Zanetti

update mock and test

161. By Michael Zanetti

improve comment

Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: