Ubuntu Notes app

Merge lp://staging/~mzanetti/reminders-app/only-resources into lp://staging/reminders-app

  1. only-resources
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Michael Zanetti
Approved revision: 290
Merged at revision: 297
Proposed branch: lp://staging/~mzanetti/reminders-app/only-resources
Merge into: lp://staging/reminders-app
Prerequisite: lp://staging/~rpadovani/reminders-app/updatedRole
Diff against target: 444 lines (+84/-47)
10 files modified
po/com.ubuntu.reminders.pot (+50/-30)
src/libqtevernote/jobs/evernotejob.cpp (+3/-0)
src/libqtevernote/jobs/evernotejob.h (+0/-1)
src/libqtevernote/jobs/fetchnotejob.cpp (+6/-5)
src/libqtevernote/jobs/fetchnotejob.h (+8/-3)
src/libqtevernote/jobs/savenotebookjob.h (+2/-0)
src/libqtevernote/jobs/savenotejob.h (+2/-0)
src/libqtevernote/jobs/savetagjob.h (+2/-0)
src/libqtevernote/notesstore.cpp (+8/-6)
src/libqtevernote/notesstore.h (+3/-2)
To merge this branch: bzr merge lp://staging/~mzanetti/reminders-app/only-resources
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Approve
Review via email: mp+239605@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-10-24.

Commit message

Don't reload the note's content when reloading a note for its resources

Description of the change

This changes the code to only load resources if we're interested in those instead of reloading the content along with the images. Should slightly improve performance when loading images from the server

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:288
http://91.189.93.70:8080/job/reminders-app-ci/570/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1266
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1266/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/266

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/570/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:289
http://91.189.93.70:8080/job/reminders-app-ci/582/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/34
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/34/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/3

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/582/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) :
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/284/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/61/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/6/console

review: Needs Fixing (continuous-integration)
lp://staging/~mzanetti/reminders-app/only-resources updated
290. By Michael Zanetti

merge trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:290
http://91.189.93.70:8080/job/reminders-app-ci/591/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/63
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/63/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/12

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/591/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches