Ubuntu Notes app

Merge lp://staging/~mzanetti/reminders-app/improve-reminders-delegate into lp://staging/reminders-app

  1. improve-reminders-delegate
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: David Planella
Approved revision: 292
Merged at revision: 294
Proposed branch: lp://staging/~mzanetti/reminders-app/improve-reminders-delegate
Merge into: lp://staging/reminders-app
Diff against target: 31 lines (+4/-1)
2 files modified
src/app/qml/components/RemindersDelegate.qml (+3/-1)
src/app/qml/ui/RemindersPage.qml (+1/-0)
To merge this branch: bzr merge lp://staging/~mzanetti/reminders-app/improve-reminders-delegate
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+240940@code.staging.launchpad.net

Commit message

Improve reminders delegate

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:292
http://91.189.93.70:8080/job/reminders-app-ci/586/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/47
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/47/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/7

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/586/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

LGTM, and it even fixes the related bug whereby the list content was shown "behind" the header when scrolling down.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches