Merge lp://staging/~mzanetti/reminders-app/get-username into lp://staging/reminders-app
Proposed by
Michael Zanetti
| Status: | Merged |
|---|---|
| Approved by: | Michael Zanetti |
| Approved revision: | 15 |
| Merged at revision: | 16 |
| Proposed branch: | lp://staging/~mzanetti/reminders-app/get-username |
| Merge into: | lp://staging/reminders-app |
| Prerequisite: | lp://staging/~mzanetti/reminders-app/rework-error-handling |
| Diff against target: |
1692 lines (+720/-345) 30 files modified
src/app/qml/reminders-app.qml (+8/-1) src/app/qml/ui/AccountSelectorPage.qml (+1/-1) src/plugin/Evernote/Evernote.pro (+10/-2) src/plugin/Evernote/evernoteconnection.cpp (+190/-0) src/plugin/Evernote/evernoteconnection.h (+101/-0) src/plugin/Evernote/evernoteplugin.cpp (+14/-2) src/plugin/Evernote/jobs/createnotejob.cpp (+2/-2) src/plugin/Evernote/jobs/createnotejob.h (+4/-5) src/plugin/Evernote/jobs/deletenotejob.cpp (+2/-2) src/plugin/Evernote/jobs/deletenotejob.h (+4/-4) src/plugin/Evernote/jobs/evernotejob.cpp (+12/-19) src/plugin/Evernote/jobs/evernotejob.h (+3/-8) src/plugin/Evernote/jobs/fetchnotebooksjob.cpp (+2/-2) src/plugin/Evernote/jobs/fetchnotebooksjob.h (+4/-4) src/plugin/Evernote/jobs/fetchnotejob.cpp (+2/-2) src/plugin/Evernote/jobs/fetchnotejob.h (+4/-4) src/plugin/Evernote/jobs/fetchnotesjob.cpp (+4/-2) src/plugin/Evernote/jobs/fetchnotesjob.h (+4/-4) src/plugin/Evernote/jobs/fetchusernamejob.cpp (+38/-0) src/plugin/Evernote/jobs/fetchusernamejob.h (+43/-0) src/plugin/Evernote/jobs/notesstorejob.cpp (+39/-0) src/plugin/Evernote/jobs/notesstorejob.h (+44/-0) src/plugin/Evernote/jobs/savenotejob.cpp (+2/-2) src/plugin/Evernote/jobs/savenotejob.h (+4/-4) src/plugin/Evernote/jobs/userstorejob.cpp (+39/-0) src/plugin/Evernote/jobs/userstorejob.h (+46/-0) src/plugin/Evernote/notesstore.cpp (+24/-131) src/plugin/Evernote/notesstore.h (+13/-44) src/plugin/Evernote/userstore.cpp (+38/-95) src/plugin/Evernote/userstore.h (+19/-5) |
| To merge this branch: | bzr merge lp://staging/~mzanetti/reminders-app/get-username |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
implement initial userstore. split connection handling into EvernoteConnection
Description of the change
This implements the beginning of the UserStore. So far it has only one property "username" which is what we will need in OnlineAccounts.
I have moved the connection setup into a new class "EvernoteConnec
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Alan Pope 🍺🐧🐱 🦄 (popey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:15
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://