Ubuntu Notes app

Merge lp://staging/~mzanetti/reminders-app/animated-delete into lp://staging/reminders-app

  1. animated-delete
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Work in progress
Proposed branch: lp://staging/~mzanetti/reminders-app/animated-delete
Merge into: lp://staging/reminders-app
Diff against target: 44 lines (+12/-0)
3 files modified
src/app/qml/ui/NotebooksPage.qml (+4/-0)
src/app/qml/ui/NotesPage.qml (+4/-0)
src/app/qml/ui/TagsPage.qml (+4/-0)
To merge this branch: bzr merge lp://staging/~mzanetti/reminders-app/animated-delete
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Riccardo Padovani Needs Fixing
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+261904@code.staging.launchpad.net

Commit message

Add an animation when deleting things

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:454
http://91.189.93.70:8080/job/reminders-app-ci/757/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2929
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2929/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/359
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/179

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/757/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

You forgot reminders page, apart from that, good work!

review: Needs Fixing
Reply
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Hmm... not so sure about this one any more. Problem is that it seems to mess up the notes list because of the section headers...

Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:454
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/25/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/108/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/25/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Putting it to Work in Proress because this triggers a bug in QML in some cases. Better not having the nice animations than breaking sometimes.

TODO: On Qt upgrades of the platform enable this and test if deleting items behaves properly and doesn't mess up the list. Maybe we can land it some day.

Reply

Unmerged revisions

454. By Michael Zanetti

add an animation when deleting items

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches