Merge lp://staging/~mwhudson/loggerhead/bug-321325 into lp://staging/loggerhead
Proposed by
Michael Hudson-Doyle
| Status: | Merged |
|---|---|
| Approved by: | j.c.sackett |
| Approved revision: | 462 |
| Merged at revision: | 463 |
| Proposed branch: | lp://staging/~mwhudson/loggerhead/bug-321325 |
| Merge into: | lp://staging/loggerhead |
| Diff against target: |
53 lines (+8/-8) 2 files modified
loggerhead/history.py (+4/-7) loggerhead/templates/revisionfilechanges.pt (+4/-1) |
| To merge this branch: | bzr merge lp://staging/~mwhudson/loggerhead/bug-321325 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| j.c.sackett (community) | Approve | ||
| Richard Harding (community) | code* | Approve | |
|
Review via email:
|
|||
Description of the change
This branch makes two changes in the area of showing exe-bit changes in the revision page:
1) It shows a * by the file name if the exe bit has changed
2) It does not make the name a link if _only_ the exe bit has changed
It doesn't show in which direction the exe bit has changed, because report_changes doesn't tell us.
Kind changes are still not reported at all, but oh well, they can be done if someone actually cares.
To post a comment you must log in.
Revision history for this message
| Richard Harding (rharding) wrote | # |
review:
Needs Information
(code*)
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
Revision history for this message
| Richard Harding (rharding) | # |
review:
Approve
(code*)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Michael, why is file_id removed along with the change? I don't see where this report method is called from, so I'm not sure if it's something that isn't needed any more, but it seems that it's not related to the rest of the change to add the * on exe changes.