Launchpad itself

Merge lp://staging/~mwhudson/launchpad/no-hosted-area into lp://staging/launchpad

  1. no-hosted-area
  2. Merge into devel
Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 10828
Proposed branch: lp://staging/~mwhudson/launchpad/no-hosted-area
Merge into: lp://staging/launchpad
Diff against target: 9694 lines (+3175/-2889)
146 files modified
Makefile (+4/-5)
bzrplugins/lpserve.py (+4/-4)
configs/development/launchpad-lazr.conf (+2/-2)
configs/testrunner/launchpad-lazr.conf (+3/-7)
cronscripts/merge-proposal-jobs.py (+22/-30)
cronscripts/mirror-prober.sh (+2/-2)
cronscripts/nightly.sh (+14/-14)
cronscripts/publishing/cron.germinate (+1/-1)
cronscripts/publishing/maintenance-check.py (+217/-29)
cronscripts/update_preview_diffs.py (+0/-38)
database/replication/Makefile (+15/-36)
database/replication/authdb_create.sql (+0/-885)
database/replication/authdb_drop.sql (+0/-14)
database/replication/authdb_sequences.sql (+0/-22)
database/replication/helpers.py (+13/-30)
database/replication/initialize.py (+7/-54)
database/replication/new-slave.py (+37/-43)
database/replication/populate_auth_replication_set.py (+0/-177)
database/replication/preamble.py (+1/-1)
database/replication/repair-restored-db.py (+1/-1)
database/replication/report.py (+1/-1)
database/replication/slon_ctl.py (+1/-1)
database/replication/sync.py (+1/-1)
database/schema/diagram.py (+1/-1)
database/schema/emptytables.py (+1/-1)
database/schema/fti.py (+1/-1)
database/schema/online_fti_updater.py (+1/-1)
database/schema/patch-2207-47-0.sql (+6/-0)
database/schema/patch-2207-48-0.sql (+27/-0)
database/schema/pending/add-mailing-list-experts.py (+1/-1)
database/schema/pending/create-openid-rp-configs.py (+1/-1)
database/schema/pending/gnu-savannah-celebrity.py (+1/-1)
database/schema/pending/migrate_kde_potemplates.py (+1/-1)
database/schema/pending/new-person-columns.py (+1/-1)
database/schema/pending/patch-2207-49-0.sql (+16/-0)
database/schema/pending/prune-nonce.py (+1/-1)
database/schema/pending/update-shippingrequest-types.py (+1/-1)
database/schema/pending/update-translation-credits.py (+3/-3)
database/schema/reset_sequences.py (+1/-1)
database/schema/security.cfg (+10/-96)
database/schema/security.py (+1/-1)
database/schema/sort_sql.py (+1/-1)
database/schema/trusted.sql (+33/-33)
database/schema/unautovacuumable.py (+1/-1)
database/schema/upgrade.py (+5/-4)
lib/canonical/config/schema-lazr.conf (+28/-0)
lib/canonical/launchpad/daemons/tachandler.py (+4/-4)
lib/canonical/launchpad/doc/product-update-remote-product-script.txt (+1/-1)
lib/canonical/launchpad/scripts/garbo.py (+2/-151)
lib/canonical/launchpad/scripts/tests/test_garbo.py (+0/-56)
lib/contrib/glock.py (+1/-1)
lib/lp/answers/doc/expiration.txt (+1/-1)
lib/lp/archivepublisher/publishing.py (+31/-1)
lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py (+8/-1)
lib/lp/archivepublisher/tests/test_generate_ppa_htaccess.py (+42/-0)
lib/lp/archivepublisher/tests/test_publisher.py (+51/-31)
lib/lp/bugs/browser/bugwatch.py (+60/-1)
lib/lp/bugs/browser/configure.zcml (+6/-0)
lib/lp/bugs/browser/tests/bugwatch-views.txt (+83/-1)
lib/lp/bugs/configure.zcml (+4/-1)
lib/lp/bugs/doc/bug-watch-activity.txt (+9/-5)
lib/lp/bugs/doc/bugnotification-sending.txt (+1/-1)
lib/lp/bugs/doc/bugtask-expiration.txt (+1/-1)
lib/lp/bugs/doc/bugtask.txt (+1/-1)
lib/lp/bugs/doc/bugwatch.txt (+84/-0)
lib/lp/bugs/doc/checkwatches.txt (+1/-1)
lib/lp/bugs/doc/cve-update.txt (+2/-2)
lib/lp/bugs/interfaces/bugwatch.py (+52/-0)
lib/lp/bugs/model/bugwatch.py (+63/-3)
lib/lp/bugs/scripts/bugheat.py (+5/-5)
lib/lp/bugs/scripts/checkwatches/scheduler.py (+4/-4)
lib/lp/bugs/scripts/tests/test_bugheat.py (+3/-3)
lib/lp/bugs/stories/bugwatches/xx-bugwatch-errors.txt (+16/-2)
lib/lp/bugs/stories/bugwatches/xx-edit-bugwatch.txt (+123/-0)
lib/lp/bugs/templates/bugwatch-editform.pt (+4/-0)
lib/lp/bugs/templates/bugwatch-portlet-activity.pt (+44/-0)
lib/lp/bugs/tests/test_apportjob.py (+1/-1)
lib/lp/bugs/tests/test_bugheat.py (+1/-1)
lib/lp/code/configure.zcml (+68/-26)
lib/lp/code/doc/branch-merge-proposal-notifications.txt (+11/-5)
lib/lp/code/doc/codereviewcomment.txt (+18/-0)
lib/lp/code/interfaces/branchmergeproposal.py (+71/-13)
lib/lp/code/interfaces/codehosting.py (+12/-0)
lib/lp/code/interfaces/codereviewcomment.py (+4/-0)
lib/lp/code/mail/branch.py (+11/-12)
lib/lp/code/mail/branchmergeproposal.py (+8/-57)
lib/lp/code/mail/codereviewcomment.py (+14/-5)
lib/lp/code/mail/tests/test_branch.py (+33/-5)
lib/lp/code/mail/tests/test_branchmergeproposal.py (+150/-79)
lib/lp/code/mail/tests/test_codehandler.py (+22/-26)
lib/lp/code/mail/tests/test_codereviewcomment.py (+11/-2)
lib/lp/code/model/branchmergeproposal.py (+10/-13)
lib/lp/code/model/branchmergeproposaljob.py (+368/-25)
lib/lp/code/model/branchtarget.py (+0/-17)
lib/lp/code/model/codereviewcomment.py (+8/-0)
lib/lp/code/model/tests/test_branchcloud.py (+4/-3)
lib/lp/code/model/tests/test_branchmergeproposaljobs.py (+349/-0)
lib/lp/code/model/tests/test_branchmergeproposals.py (+30/-248)
lib/lp/code/model/tests/test_diff.py (+4/-0)
lib/lp/code/scripts/tests/test_create_merge_proposals.py (+3/-3)
lib/lp/code/scripts/tests/test_merge_proposal_jobs.py (+9/-47)
lib/lp/code/scripts/tests/test_reclaim_branch_space.py (+3/-4)
lib/lp/code/scripts/tests/test_scan_branches.py (+2/-2)
lib/lp/code/scripts/tests/test_sendbranchmail.py (+13/-8)
lib/lp/code/scripts/tests/test_update_preview_diffs.py (+0/-93)
lib/lp/code/scripts/tests/test_upgrade_branches.py (+4/-4)
lib/lp/code/stories/webservice/xx-code-import.txt (+1/-0)
lib/lp/code/subscribers/branchmergeproposal.py (+55/-0)
lib/lp/code/tests/helpers.py (+16/-0)
lib/lp/code/xmlrpc/codehosting.py (+33/-8)
lib/lp/code/xmlrpc/tests/test_codehosting.py (+86/-1)
lib/lp/codehosting/inmemory.py (+26/-3)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+6/-5)
lib/lp/codehosting/scanner/tests/test_mergedetection.py (+14/-2)
lib/lp/codehosting/sftp.py (+2/-5)
lib/lp/codehosting/tests/servers.py (+1/-1)
lib/lp/codehosting/tests/test_acceptance.py (+108/-114)
lib/lp/codehosting/vfs/branchfs.py (+106/-72)
lib/lp/codehosting/vfs/branchfsclient.py (+2/-2)
lib/lp/codehosting/vfs/tests/test_branchfs.py (+128/-51)
lib/lp/codehosting/vfs/tests/test_filesystem.py (+1/-1)
lib/lp/hardwaredb/doc/hwdb-submission.txt (+4/-4)
lib/lp/registry/doc/distribution-mirror.txt (+5/-5)
lib/lp/registry/doc/person-karma.txt (+1/-1)
lib/lp/registry/doc/sourceforge-remote-products.txt (+1/-1)
lib/lp/registry/doc/standing.txt (+2/-2)
lib/lp/services/job/runner.py (+29/-10)
lib/lp/services/job/tests/test_runner.py (+6/-2)
lib/lp/services/mail/sendmail.py (+27/-24)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+2/-2)
lib/lp/soyuz/doc/gina.txt (+1/-1)
lib/lp/soyuz/doc/manage-chroot.txt (+1/-1)
lib/lp/soyuz/doc/package-cache-script.txt (+1/-1)
lib/lp/soyuz/scripts/publishdistro.py (+33/-20)
lib/lp/soyuz/scripts/tests/test_processupload.py (+1/-1)
lib/lp/testing/factory.py (+2/-0)
lib/lp/translations/doc/distroseries-translations-copy.txt (+4/-2)
lib/lp/translations/doc/fix_translation_credits.txt (+2/-1)
lib/lp/translations/doc/poexport-language-pack.txt (+2/-1)
lib/lp/translations/doc/poexport-request.txt (+1/-1)
lib/lp/translations/doc/pofile-verify-stats.txt (+2/-2)
lib/lp/translations/doc/rosetta-poimport-script.txt (+1/-1)
lib/lp/translations/doc/sourcepackagerelease-translations.txt (+3/-2)
lib/lp/translations/doc/translations-export-to-branch.txt (+1/-1)
lib/lp/translations/scripts/tests/test_translations_to_branch.py (+1/-1)
scripts/close-account.py (+19/-11)
To merge this branch: bzr merge lp://staging/~mwhudson/launchpad/no-hosted-area
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+23643@code.staging.launchpad.net

Description of the change

Hi Tim,

This branch makes the ssh codehosting server only use one area (the mirrored area) rather than the mirrored and hosted area.

In addition, on branch unlock, rather than requesting the branch be mirrored, the codehosting server calls a method that updates the fields the puller updates for hosted branches, hopefully reducing latency.

In the next pipe I extend this branchChanged endpoint to also record the branch format.

There's obviously no way this branch can land on its own, it will break many many tests.

Cheers,
mwh

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

lib/lp/code/xmlrpc/codehosting.py
in: def branchChanged(self, branch_id, stacked_on_location, last_revision_id):
  + branch.last_mirrored = datetime.datetime.now(pytz.UTC)
should probably be using UTC_NOW

lib/lp/codehosting/inmemory.py branchChanged event should use UTC_NOW too.

then:
test_branchChanged_sets_last_mirrored
can use:
     self.assertSqlAttributeEqualsDate(
        branch, 'last_mirrored', UTC_NOW)

def test_branchChanged_doesnt_create_scan_job_for_noop_change(self):
    # XXX Is this even the right thing to do?
It will be with your next pipe.

lib/lp/codehosting/vfs/branchfs.py
class LaunchpadServer (I think - around line 558)
the __init__ method still refers to the authserver, also there is a
XXX comment that I'm wondering whether we can remove it or not.

lib/lp/codehosting/vfs/tests/test_branchfs.py - still refers to an
authserver too.

# XXX Maaaybe we could complain on stderr here?
  - Not following our XXX format, and is this something we want to do?

# XXX: JonathanLange 2007-05-29: The 'chroot' line lacks a unit test.
I don't suppose you want to add a unit test for this?

General Note: we probably want to rename config.codehosting.mirrored_branches
at some stage.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

On 19/04/10 16:20, Tim Penhey wrote:
> lib/lp/code/xmlrpc/codehosting.py
> in: def branchChanged(self, branch_id, stacked_on_location, last_revision_id):
> + branch.last_mirrored = datetime.datetime.now(pytz.UTC)
> should probably be using UTC_NOW
>
> lib/lp/codehosting/inmemory.py branchChanged event should use UTC_NOW too.
>
> then:
> test_branchChanged_sets_last_mirrored
> can use:
> self.assertSqlAttributeEqualsDate(
> branch, 'last_mirrored', UTC_NOW)

Yeah OK.

> def test_branchChanged_doesnt_create_scan_job_for_noop_change(self):
> # XXX Is this even the right thing to do?
> It will be with your next pipe.

Right, I'll delete the comment.

> lib/lp/codehosting/vfs/branchfs.py
> class LaunchpadServer (I think - around line 558)
> the __init__ method still refers to the authserver, also there is a
> XXX comment that I'm wondering whether we can remove it or not.

Grar, can I fix this in the later pipe that combines the two endpoints?

> lib/lp/codehosting/vfs/tests/test_branchfs.py - still refers to an
> authserver too.

This too.

> # XXX Maaaybe we could complain on stderr here?
> - Not following our XXX format, and is this something we want to do?

Nah, I'll delete the comment.

> # XXX: JonathanLange 2007-05-29: The 'chroot' line lacks a unit test.
> I don't suppose you want to add a unit test for this?

OK. It's a bit terrible though.

> General Note: we probably want to rename config.codehosting.mirrored_branches
> at some stage.

Given recent edge rollout funnies, I don't know how we'd do this :/ But
yeah, it doesn't really make sense.

Interdiff attached.

Cheers,
mwh

no-hosted-area-progress.diff
1=== modified file 'lib/lp/code/xmlrpc/codehosting.py'
2--- lib/lp/code/xmlrpc/codehosting.py 2010-04-19 10:45:14 +0000
3+++ lib/lp/code/xmlrpc/codehosting.py 2010-04-19 21:57:33 +0000
4@@ -23,6 +23,16 @@
5 from zope.security.proxy import removeSecurityProxy
6 from zope.security.management import endInteraction
7
8+from canonical.database.constants import UTC_NOW
9+from canonical.launchpad.validators import LaunchpadValidationError
10+from canonical.launchpad.webapp import LaunchpadXMLRPCView
11+from canonical.launchpad.webapp.authorization import check_permission
12+from canonical.launchpad.webapp.interaction import setupInteractionForPerson
13+from canonical.launchpad.webapp.interfaces import (
14+ NameLookupFailed, NotFoundError)
15+from canonical.launchpad.xmlrpc import faults
16+from canonical.launchpad.xmlrpc.helpers import return_fault
17+
18 from lp.code.errors import UnknownBranchTypeError
19 from lp.code.enums import BranchType
20 from lp.code.interfaces.branch import BranchCreationException
21@@ -38,14 +48,6 @@
22 from lp.registry.interfaces.product import NoSuchProduct
23 from lp.services.scripts.interfaces.scriptactivity import IScriptActivitySet
24 from lp.services.utils import iter_split
25-from canonical.launchpad.validators import LaunchpadValidationError
26-from canonical.launchpad.webapp import LaunchpadXMLRPCView
27-from canonical.launchpad.webapp.authorization import check_permission
28-from canonical.launchpad.webapp.interaction import setupInteractionForPerson
29-from canonical.launchpad.webapp.interfaces import (
30- NameLookupFailed, NotFoundError)
31-from canonical.launchpad.xmlrpc import faults
32-from canonical.launchpad.xmlrpc.helpers import return_fault
33
34
35 UTC = pytz.timezone('UTC')
36@@ -262,7 +264,7 @@
37 branch.mirror_status_message = (
38 'Invalid stacked on location: ' + stacked_on_location)
39 branch.stacked_on = stacked_on_branch
40- branch.last_mirrored = datetime.datetime.now(pytz.UTC)
41+ branch.last_mirrored = UTC_NOW
42 if branch.last_mirrored_id != last_revision_id:
43 branch.last_mirrored_id = last_revision_id
44 getUtility(IBranchScanJobSource).create(branch)
45
46=== modified file 'lib/lp/code/xmlrpc/tests/test_codehosting.py'
47--- lib/lp/code/xmlrpc/tests/test_codehosting.py 2010-04-19 04:06:23 +0000
48+++ lib/lp/code/xmlrpc/tests/test_codehosting.py 2010-04-19 22:09:34 +0000
49@@ -15,7 +15,6 @@
50 from zope.component import getUtility
51 from zope.security.proxy import removeSecurityProxy
52
53-from lp.codehosting.inmemory import InMemoryFrontend
54 from canonical.database.constants import UTC_NOW
55 from canonical.launchpad.ftests import ANONYMOUS, login, logout
56 from lp.services.scripts.interfaces.scriptactivity import (
57@@ -40,6 +39,8 @@
58 BranchFileSystem, BranchPuller, LAUNCHPAD_ANONYMOUS, LAUNCHPAD_SERVICES,
59 run_with_login)
60
61+from lp.codehosting.inmemory import InMemoryFrontend
62+
63
64 UTC = pytz.timezone('UTC')
65
66@@ -739,9 +740,11 @@
67 # current time.
68 branch = self.factory.makeAnyBranch()
69 self.branchfs.branchChanged(branch.id, '', '')
70- # We can't test "now" precisely, but lets check that last_mirrored was
71- # set to _something_.
72- self.assertIsNot(None, branch.last_mirrored)
73+ if self.frontend == LaunchpadDatabaseFrontend:
74+ self.assertSqlAttributeEqualsDate(
75+ branch, 'last_mirrored', UTC_NOW)
76+ else:
77+ self.assertIs(UTC_NOW, branch.last_mirrored)
78
79 def test_branchChanged_records_bogus_stacked_on_url(self):
80 # If a bogus location is passed in as the stacked_on parameter,
81@@ -772,7 +775,7 @@
82
83 def test_branchChanged_creates_scan_job(self):
84 # branchChanged() creates a scan job for the branch.
85- if not isinstance(self.frontend, LaunchpadDatabaseFrontend):
86+ if self.frontend != LaunchpadDatabaseFrontend:
87 return
88 branch = self.factory.makeAnyBranch()
89 jobs = list(getUtility(IBranchScanJobSource).iterReady())
90@@ -782,8 +785,7 @@
91 self.assertEqual(1, len(jobs))
92
93 def test_branchChanged_doesnt_create_scan_job_for_noop_change(self):
94- # XXX Is this even the right thing to do?
95- if not isinstance(self.frontend, LaunchpadDatabaseFrontend):
96+ if self.frontend != LaunchpadDatabaseFrontend:
97 return
98 branch = self.factory.makeAnyBranch()
99 removeSecurityProxy(branch).last_mirrored_id = 'rev1'
100
101=== modified file 'lib/lp/codehosting/inmemory.py'
102--- lib/lp/codehosting/inmemory.py 2010-04-19 04:06:23 +0000
103+++ lib/lp/codehosting/inmemory.py 2010-04-19 22:04:00 +0000
104@@ -9,18 +9,18 @@
105 'XMLRPCWrapper',
106 ]
107
108-import datetime
109 import operator
110 from xmlrpclib import Fault
111
112 from bzrlib.urlutils import escape, unescape
113
114-import pytz
115-
116 from zope.component import adapter, getSiteManager
117 from zope.interface import implementer
118
119 from canonical.database.constants import UTC_NOW
120+from canonical.launchpad.validators import LaunchpadValidationError
121+from canonical.launchpad.xmlrpc import faults
122+
123 from lp.code.errors import UnknownBranchTypeError
124 from lp.code.model.branchnamespace import BranchNamespaceSet
125 from lp.code.model.branchtarget import (
126@@ -31,12 +31,10 @@
127 from lp.code.interfaces.codehosting import (
128 BRANCH_TRANSPORT, CONTROL_TRANSPORT, LAUNCHPAD_ANONYMOUS,
129 LAUNCHPAD_SERVICES)
130+from lp.code.xmlrpc.codehosting import datetime_from_tuple
131 from lp.registry.interfaces.pocket import PackagePublishingPocket
132 from lp.services.utils import iter_split
133 from lp.testing.factory import ObjectFactory
134-from canonical.launchpad.validators import LaunchpadValidationError
135-from lp.code.xmlrpc.codehosting import datetime_from_tuple
136-from canonical.launchpad.xmlrpc import faults
137
138
139 class FakeStore:
140@@ -637,7 +635,7 @@
141 branch.mirror_status_message = (
142 'Invalid stacked on location: ' + stacked_on_location)
143 branch.stacked_on = stacked_on_branch
144- branch.last_mirrored = datetime.datetime.now(pytz.UTC)
145+ branch.last_mirrored = UTC_NOW
146 if branch.last_mirrored_id != last_revision_id:
147 branch.last_mirrored_id = last_revision_id
148 return True
149
150=== modified file 'lib/lp/codehosting/vfs/branchfs.py'
151--- lib/lp/codehosting/vfs/branchfs.py 2010-04-16 00:55:24 +0000
152+++ lib/lp/codehosting/vfs/branchfs.py 2010-04-19 22:33:52 +0000
153@@ -639,7 +639,6 @@
154 # Assume it's a relative path.
155 return stacked_on_url
156 uri = URI(stacked_on_url)
157- # XXX Maaaybe we could complain on stderr here?
158 if uri.scheme not in ['http', 'bzr+ssh', 'sftp']:
159 return stacked_on_url
160 launchpad_domain = config.vhost.mainsite.hostname
161@@ -710,7 +709,6 @@
162
163 branch_url = urlutils.local_path_to_url(branch_directory)
164 branchfs_client = xmlrpclib.ServerProxy(branchfs_endpoint_url)
165- # XXX: JonathanLange 2007-05-29: The 'chroot' line lacks a unit test.
166 branch_transport = get_chrooted_transport(branch_url)
167 lp_server = LaunchpadServer(
168 BlockingProxy(branchfs_client), user_id, branch_transport,
169
170=== modified file 'lib/lp/codehosting/vfs/tests/test_branchfs.py'
171--- lib/lp/codehosting/vfs/tests/test_branchfs.py 2010-04-09 06:28:34 +0000
172+++ lib/lp/codehosting/vfs/tests/test_branchfs.py 2010-04-19 22:33:25 +0000
173@@ -17,6 +17,7 @@
174 from bzrlib.transport import (
175 get_transport, _get_protocol_handlers, register_transport, Server,
176 unregister_transport)
177+from bzrlib.transport.chroot import ChrootTransport
178 from bzrlib.transport.memory import MemoryServer, MemoryTransport
179 from bzrlib.urlutils import escape, local_path_to_url
180
181@@ -26,7 +27,7 @@
182 from lp.codehosting.vfs.branchfs import (
183 AsyncLaunchpadTransport, BranchTransportDispatch,
184 DirectDatabaseLaunchpadServer, LaunchpadInternalServer, LaunchpadServer,
185- TransportDispatch, UnknownTransportType, branch_id_to_path)
186+ TransportDispatch, UnknownTransportType, branch_id_to_path, get_lp_server)
187 from lp.codehosting.inmemory import InMemoryFrontend, XMLRPCWrapper
188 from lp.codehosting.sftp import FatLocalTransport
189 from lp.codehosting.vfs.transport import AsyncVirtualTransport
190@@ -1005,6 +1006,17 @@
191 '/%s/.bzr/goodbye.txt' % self.read_only_branch)
192
193
194+class TestGetLPServer(TestCase):
195+ """Tests for `get_lp_server`."""
196+
197+ def test_chrooting(self):
198+ # Test that get_lp_server return a server that ultimately backs onto a
199+ # ChrootTransport.
200+ lp_server = get_lp_server(1, 'http://xmlrpc.example.invalid', '')
201+ transport = lp_server._transport_dispatch._rw_dispatch.base_transport
202+ self.assertIsInstance(transport, ChrootTransport)
203+
204+
205 def test_suite():
206 return unittest.TestLoader().loadTestsFromName(__name__)
207
Revision history for this message
Tim Penhey (thumper) wrote :

 merge approved

On Tue, 20 Apr 2010 10:39:16 you wrote:
> On 19/04/10 16:20, Tim Penhey wrote:
> > lib/lp/codehosting/vfs/branchfs.py
> > class LaunchpadServer (I think - around line 558)
> > the __init__ method still refers to the authserver, also there is a
> > XXX comment that I'm wondering whether we can remove it or not.
>
> Grar, can I fix this in the later pipe that combines the two endpoints?

Yep, sure.

> > lib/lp/codehosting/vfs/tests/test_branchfs.py - still refers to an
> > authserver too.
>
> This too.

Yes.

Tim

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.