Merge lp://staging/~mwhudson/launchpad/allow-import-password into lp://staging/launchpad
Proposed by
Michael Hudson-Doyle
| Status: | Merged |
|---|---|
| Approved by: | Michael Hudson-Doyle |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~mwhudson/launchpad/allow-import-password |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
144 lines (+31/-15) 4 files modified
lib/lp/code/browser/codeimport.py (+4/-3) lib/lp/code/interfaces/codeimport.py (+1/-1) lib/lp/code/stories/codeimport/xx-admin-codeimport.txt (+8/-7) lib/lp/code/stories/codeimport/xx-create-codeimport.txt (+18/-4) |
| To merge this branch: | bzr merge lp://staging/~mwhudson/launchpad/allow-import-password |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Penhey (community) | Approve | ||
| Jeroen T. Vermeulen (community) | code | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Allow a username and password to be specified in a code import's URL
Description of the change
Hi,
This branch adds the ability to specify a username and password in code import urls.
Cheers,
mwh
To post a comment you must log in.
Revision history for this message
| Tim Penhey (thumper) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
As per IRC, I have one problem with this: you're inviting users to enter complete login credentials which will then be shown publicly in the UI.
An option you proffered was a warning text. Another is to ensure that the password is never displayed except to the user who entered it.