curtin

Merge ~mwhudson/curtin:always-devpath into curtin:master

  1. Git
  2. lp:~mwhudson/curtin
  3. always-devpath
  4. Merge into master
Proposed by Michael Hudson-Doyle
Status: Needs review
Proposed branch: ~mwhudson/curtin:always-devpath
Merge into: curtin:master
Diff against target: 70 lines (+12/-7)
3 files modified
curtin/commands/block_meta.py (+9/-7)
tests/unittests/test_commands_block_meta.py (+1/-0)
tests/unittests/test_curthooks.py (+2/-0)
Reviewer Review Type Date Requested Status
Dan Bungert Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+415876@code.staging.launchpad.net

Commit message

block_meta: have get_path_to_storage_volume always return device node

Specifically, return /dev/dm-X for device-mapper paths, not /dev/mapper/foo.

I thought this would fix the multipath reuse vmtests but it didn't.
It still seems like a good idea though.

Description of the change

I took a look at the failing vmtests and I think this is the only change needed for curtin (vs changes to test data or code).

Curtin really needs a block device object.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:96b8b5b9d43b2a5016951b26c6cfe9f72d82af82
https://jenkins.ubuntu.com/server/job/curtin-ci/250/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/250/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/250/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/250/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/250/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/250//rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:1afde541b95fad6481121eae9edddf0a0a6f24b2
https://jenkins.ubuntu.com/server/job/curtin-ci/252/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/252/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/252/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/252/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/252/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/252//rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:fe2380a8dafb5d40a602abbe7a1ef907476b2936
https://jenkins.ubuntu.com/server/job/curtin-ci/254/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/254/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/254/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/254/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/254/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/254//rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Hm this doesn't fix the tests. May still be a good idea but clearly not sufficient.

Reply
Revision history for this message
Dan Bungert (dbungert) :
review: Approve
Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches