Obsolete LAVA Test

Merge lp://staging/~mwasilew/lava-test/lava-test-perf into lp://staging/lava-test/0.0

Proposed by Milosz Wasilewski on 2013-06-07

Status:	Rejected
Rejected by:	Neil Williams on 2014-07-10
Proposed branch:	lp://staging/~mwasilew/lava-test/lava-test-perf
Merge into:	lp://staging/lava-test/0.0
Diff against target:	88 lines (+84/-0) 1 file modified run-perf-test.sh (+84/-0)
To merge this branch:	bzr merge lp://staging/~mwasilew/lava-test/lava-test-perf
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Tyler Baker		2013-06-07	Approve on 2013-06-07
Review via email: mp+168132@code.staging.launchpad.net

Fixed regular expression to match perf test output starting with two digit number.

Revision history for this message

Tyler Baker (tyler-baker) wrote on 2013-06-07:

Approved.

review: Approve

Revision history for this message

Antonio Terceiro (terceiro) wrote on 2013-06-10:

Hi Milosz,

I'm sorry, but I can't understand this merge proposal.

lp:lava-test does not look like the right target for this, maybe you
were looking for some other repository?

Revision history for this message

Tyler Baker (tyler-baker) wrote on 2013-06-10:

I did not realize this was the lava-test repository. It should be the
linaro-maintainers repo, good catch Antonio.

On 10 June 2013 12:19, Antonio Terceiro <email address hidden> wrote:

> Hi Milosz,
>
> I'm sorry, but I can't understand this merge proposal.
>
> Compara lava-test (the branch you are proposing to merge to):
> http://bazaar.launchpad.net/~linaro-validation/lava-test/trunk/files
>
> To the branch you are proposing to merge from:
> http://bazaar.launchpad.net/~mwasilew/lava-test/lava-test-perf/files
>
> lp:lava-test does not look like the right target for this, maybe you
> were looking for some other repository?
>
> --
> https://code.launchpad.net/~mwasilew/lava-test/lava-test-perf/+merge/168132
> You are reviewing the proposed merge of
> lp:~mwasilew/lava-test/lava-test-perf into lp:lava-test.
>

--
Tyler Baker
Technical Architect, LAVA
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

Revision history for this message

Milosz Wasilewski (mwasilew) wrote on 2013-06-10:

You're absolutely right. This should go to the branch Tyler pointed.
Now I posted it for the review in the right place. Sorry for the
hassle.

milosz

On 10 June 2013 20:30, Tyler Baker <email address hidden> wrote:
> I did not realize this was the lava-test repository. It should be the
> linaro-maintainers repo, good catch Antonio.
>
> lp:~linaro-maintainers/lava-test/lava-test-perf
>
>
>
> On 10 June 2013 12:19, Antonio Terceiro <email address hidden> wrote:
>>
>> Hi Milosz,
>>
>> I'm sorry, but I can't understand this merge proposal.
>>
>> Compara lava-test (the branch you are proposing to merge to):
>> http://bazaar.launchpad.net/~linaro-validation/lava-test/trunk/files
>>
>> To the branch you are proposing to merge from:
>> http://bazaar.launchpad.net/~mwasilew/lava-test/lava-test-perf/files
>>
>> lp:lava-test does not look like the right target for this, maybe you
>> were looking for some other repository?
>>
>> --
>>
>> https://code.launchpad.net/~mwasilew/lava-test/lava-test-perf/+merge/168132
>> You are reviewing the proposed merge of
>> lp:~mwasilew/lava-test/lava-test-perf into lp:lava-test.
>
>
>
>
> --
> Tyler Baker
> Technical Architect, LAVA
> Linaro.org | Open source software for ARM SoCs
> Follow Linaro: http://www.facebook.com/pages/Linaro
> http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

9. By Milosz Wasilewski on 2013-06-07: fixed regular expression
8. By Marcin Juszkiewicz on 2013-03-25: let's assume that if /usr/bin/apt-get exists then we have Ubuntu
7. By Fathi Boudra on 2012-06-26: Test that the script is run as root and drop sudo calls.
Use gt operand for comparison (fixes incorrect test results).
Fix bashisms.
6. By Avik Sil on 2012-04-12: Enhance test output log
5. By Avik Sil on 2012-04-11: Non-interactive install of linux-linaro-tools-* package
4. By Avik Sil on 2012-04-11: Install proper linux-linaro-tools-* package
3. By Avik Sil on 2012-04-10: Add perf record data file
2. By Avik Sil on 2012-04-10: Fix grep option
1. By Avik Sil on 2012-04-10: perf test definition for lava-test