Merge lp://staging/~mvorozhtsov/unity/unity.temp_fix_865307 into lp://staging/unity
Proposed by
Mikhail Vorozhtsov
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Gord Allott | ||||
| Proposed branch: | lp://staging/~mvorozhtsov/unity/unity.temp_fix_865307 | ||||
| Merge into: | lp://staging/unity | ||||
| Diff against target: |
79 lines (+18/-4) 3 files modified
plugins/unityshell/src/unityshell.cpp (+12/-3) plugins/unityshell/src/unityshell.h (+2/-1) plugins/unityshell/unityshell.xml.in (+4/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~mvorozhtsov/unity/unity.temp_fix_865307 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gord Allott (community) | Disapprove | ||
| Marco Trevisan (Treviño) | Needs Fixing | ||
| Neil J. Patel | Pending | ||
|
Review via email:
|
|||
Description of the change
As described in LP: #865307, right now customizing "show the launcher" key leads to inconsistent behavior and the default binding effectively disables all "<Super>.." key combinations in Compiz. This branch introduces (as a temporary fix) a new key binding for just showing the Dash without activating the tapping logic or installing the hardcoded "<Super>KP_*" key combinations, meaning that it can be safely customized. Now the user can disable "show the launcher" key binding (to be able to use "<Super>.." key combinations throughout Compiz) and still have quick access to the dash.
To post a comment you must log in.
Revision history for this message
| Alex Launi (alexlauni) wrote | # |
Unmerged revisions
- 1701. By Mikhail Vorozhtsov
-
Added keybinding for just showing the Dash (can be considered as a temporary
fix for LP: #865307).
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Mh, I'm testing this, but I'm not sure I like how it works and if this the design team will accept this, as it doesn't allow to fully customize the super key, but you're just adding an alternate key binding to show the home dash...
I guess w'd need some more design input on this.
However please, fix the description string in unityshell.xml.in including that this is just an alternate keybinding to show the home dash:
+ <option name="show_dash" type="key">
+ <_short>Key to show the Dash</_short>
+ <_long>
+ </option>
Finally, to get this landed we also need a test (it can also be a manual test, i.e: http://