Merge lp://staging/~mvo/software-center/test-catview-cleanup into lp://staging/software-center
Proposed by
Michael Vogt
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~mvo/software-center/test-catview-cleanup |
| Merge into: | lp://staging/software-center |
| Diff against target: |
879 lines (+350/-246) 7 files modified
softwarecenter/backend/channel.py (+4/-4) softwarecenter/db/application.py (+5/-4) softwarecenter/testutils.py (+62/-0) softwarecenter/ui/gtk3/models/appstore2.py (+11/-5) softwarecenter/ui/gtk3/views/catview_gtk.py (+48/-21) test/gtk3/test_app.py (+2/-36) test/gtk3/test_catview.py (+218/-176) |
| To merge this branch: | bzr merge lp://staging/~mvo/software-center/test-catview-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| software-store-developers | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2012-05-22.
Description of the change
This branch refactors the test_catview.py code:
- split the TestCases for the Recommender and the Top Rated/Whats New
- remove duplicated code in the tests by using setUp()/tearDown() more efficiently
- use the patch decorator more
- avoid re-creating the DB in each test via setUpClass, this could be optimized further by just having one global instance for the entire test
To post a comment you must log in.
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
