Ubuntu Software Center

Merge lp://staging/~mvo/software-center/spinner-while-agent-runs-5.2 into lp://staging/software-center/5.2

spinner-while-agent-runs-5.2
Merge into 5.2

Proposed by Michael Vogt on 2012-08-09

Status:

Work in progress

Proposed branch:

lp://staging/~mvo/software-center/spinner-while-agent-runs-5.2

Merge into:

lp://staging/software-center/5.2

Diff against target:

202 lines (+75/-21)

4 files modified

softwarecenter/db/database.py (+32/-0)
softwarecenter/ui/gtk3/app.py (+1/-18)
softwarecenter/ui/gtk3/views/appdetailsview.py (+22/-2)
test/gtk3/test_appdetailsview.py (+20/-1)

To merge this branch:

bzr merge lp://staging/~mvo/software-center/spinner-while-agent-runs-5.2

High

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Gary Lasker (community)		2012-08-09	Approve on 2012-08-14
Review via email: mp+118978@code.staging.launchpad.net

Description of the change

This branch adds a spinner that is displayed if a app is not found but there is a update going on in the background. No string change as this is targeted for precise.

Revision history for this message

Michael Vogt (mvo) wrote on 2012-08-09:

We could use the "In Progress..." string that we have already, but there is really no good one in our pot.

lp://staging/~mvo/software-center/spinner-while-agent-runs-5.2 updated on 2012-08-10

3079. By Michael Vogt on 2012-08-10: softwarecenter/ui/gtk3/widgets/spinner.py: remove spurious change

Revision history for this message

Gary Lasker (gary-lasker) wrote on 2012-08-14:

Hi Michael, thanks for this! The code looks fine to me. I especially like that you moved the update-software-center-agent code out of app.py and into the backend.

I know that there was some discussion today about the UI implementation, and I believe that as a result of this you plan to do more work on this branch. I just wanted to approve it as it is in case you decide to stick with it. If you make further changes, I'll be happy to review them.

I do have one question. I noticed that the spinner is only displayed in the application's icon area and the text area to the right still prominently displays the "Not found" message. Would it be better to just show a spinner for the entire view instead? Just wondering what you think about that (since we can't change strings for the SRU, as you mentioned).

review: Approve

Unmerged revisions

3079. By Michael Vogt on 2012-08-10: softwarecenter/ui/gtk3/widgets/spinner.py: remove spurious change
3078. By Michael Vogt on 2012-08-09: add test for spinner
3077. By Michael Vogt on 2012-08-09: fix pep8
3076. By Michael Vogt on 2012-08-09: add "update-software-center-agent-finished" signal to the db
3075. By Michael Vogt on 2012-08-09: softwarecenter/ui/gtk3/views/appdetailsview.py: ensure the spinner is updated
3074. By Michael Vogt on 2012-08-09: add self.app_icon_spinner to be able to show the spinner
3073. By Michael Vogt on 2012-08-09: softwarecenter/db/database.py: fix datadir
3072. By Michael Vogt on 2012-08-09: move the update-software-center-agent functionality from the app.py into the DB