Merge lp://staging/~mvo/software-center/piston-generic-helper-offline-mode into lp://staging/software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 3022
Proposed branch: lp://staging/~mvo/software-center/piston-generic-helper-offline-mode
Merge into: lp://staging/software-center
Diff against target: 30 lines (+11/-2)
1 file modified
utils/piston-helpers/piston_generic_helper.py (+11/-2)
To merge this branch: bzr merge lp://staging/~mvo/software-center/piston-generic-helper-offline-mode
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+107362@code.staging.launchpad.net

Description of the change

Tiny branch that adds support for offline mode to the generic-helper just like for the piston_get_reviews_helper.py

Note that we could backport this at some point, but we need to be careful about regressions (I can't think
of any currently, but that does not mean anything ;)

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Very cool! I can see lobby recommendations now even when offline. This is a great kickoff to building up a nicely effective offline experience. Thanks Michael!

I'll merge this to trunk, and we can decide about backporting later.

review: Approve
Revision history for this message
Gary Lasker (gary-lasker) wrote :

...effective offline *recommendations* experience, to be more specific.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches