Merge lp://staging/~mvo/software-center/no-piston-data-means-error into lp://staging/software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 3097
Proposed branch: lp://staging/~mvo/software-center/no-piston-data-means-error
Merge into: lp://staging/software-center
Diff against target: 27 lines (+6/-2)
1 file modified
utils/piston-helpers/piston_generic_helper.py (+6/-2)
To merge this branch: bzr merge lp://staging/~mvo/software-center/no-piston-data-means-error
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+119686@code.staging.launchpad.net

Description of the change

This branch fixes the not-stopping spinner I see when testing
lp:~gary-lasker/software-center/display-cached-recommendations

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Hi Michael, thanks very much for this. As I mentioned in lp:~gary-lasker/software-center/display-cached-recommendations, relying on this error condition has the unwanted side-effect in Software Center of inexplicably hiding the lobby view's recommendations panel completely for the error case.

Therefore, I made a different fix in that branch that correctly detects the condition and displays the standard "Recommendations will appear when next online" message in the panel.

This branch, then, in not strictly needed anymore (at least for the offline recommendations case), but it seems to me that it's a good general approach to return an error if piston does not have cached data available, so I would approve this for merging if you still think it's a good idea as well.

Many thanks!

review: Approve
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Here is the corresponding merge proposal for the branch that I referred to in my previous comment:

  https://code.launchpad.net/~gary-lasker/software-center/display-cached-recommendations/+merge/119614

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Michael points out that a similar endless spinner behavior occurs when an appdetails page is viewed under the conditions described above, and this branch fixes that (in that case, it is correct behavior to simply hide the panel). I verified that this branch fixes this issue. Therefore, we should definitely merge this.

Thanks again mvo!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches