Merge lp://staging/~mvo/software-center/lp987321 into lp://staging/software-center/5.2

Proposed by Michael Vogt
Status: Merged
Merged at revision: 3029
Proposed branch: lp://staging/~mvo/software-center/lp987321
Merge into: lp://staging/software-center/5.2
Diff against target: 12 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp://staging/~mvo/software-center/lp987321
Reviewer Review Type Date Requested Status
Kiwinote Approve
Review via email: mp+106637@code.staging.launchpad.net

Description of the change

Fix too loose dependency

To post a comment you must log in.
Revision history for this message
Kiwinote (kiwinote) wrote :

Hi Michael!

I'll approve this branch, because it is obviously correct and desirable.

I'm not sure however whether it is sufficient to solve the issue from the bug. The following things confuse me slightly:
- looking at http://paste.ubuntu.com/942544/ it would seem to give the impression that humanity-icon-theme is installed; on startup we append the humanity icontheme to the icontheme which is currently in use, so it should be able to find the icons?
- gnome-icon-theme depends on the hicolor-icon-theme which includes the desired icons, so it should be able to find the icons?
I haven't managed to reproduce the issue myself yet, but perhaps you have a better idea as to what's going on?

(Please do merge the branch as is, as it's a desirable change. Thanks!)

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

hicolor-icon-theme does not itself have them, its synpatic that has them and puts them into the hicolor namespace (which is probably a mistake) and that is confusing.

Revision history for this message
Kiwinote (kiwinote) wrote :

ah, cool, thanks for the clarification!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches