Merge lp://staging/~mvo/software-center/lp971776 into lp://staging/software-center/5.2
Proposed by
Michael Vogt
| Status: | Merged |
|---|---|
| Merged at revision: | 3045 |
| Proposed branch: | lp://staging/~mvo/software-center/lp971776 |
| Merge into: | lp://staging/software-center/5.2 |
| Diff against target: |
100 lines (+33/-21) 2 files modified
softwarecenter/ui/gtk3/models/appstore2.py (+17/-12) test/gtk3/test_appstore2.py (+16/-9) |
| To merge this branch: | bzr merge lp://staging/~mvo/software-center/lp971776 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Lasker (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-06-05.
Description of the change
Fix crash when a image downloaded is invalid for whatever reason (network issues, proxy issues, pay-wall in between). This is the top #5 bug on the software-center errors.ubuntu.com subpage.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks great and should do the trick nicely! Thanks for adding the unit test for this error case. I also tested by clearing the local icon cache, everything works like a charm.
Thanks!