Merge lp://staging/~mvo/software-center/lp964433 into lp://staging/software-center
Proposed by
Michael Vogt
| Status: | Merged |
|---|---|
| Merged at revision: | 2932 |
| Proposed branch: | lp://staging/~mvo/software-center/lp964433 |
| Merge into: | lp://staging/software-center |
| Diff against target: |
69 lines (+16/-3) 2 files modified
softwarecenter/ui/gtk3/models/appstore2.py (+4/-1) softwarecenter/ui/gtk3/views/appview.py (+12/-2) |
| To merge this branch: | bzr merge lp://staging/~mvo/software-center/lp964433 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Lasker (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch fixes bug #964433.
It turns out that the bug is that:
- in appview.py we call model.set_
- this will load a initial batch of rows and the add empty placeholder rows
- because the apptreeview has a _cell_data_func the rows are requesting data
- this causes load_range to be run and that will load the documents that were meant to be empty and loaded on demand
The fix is to disconnect the model first and then after its updated set it again.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is a tricky one, well done! Thanks mvo.