Merge lp://staging/~mvo/software-center/lp959612 into lp://staging/software-center/5.2

Proposed by Michael Vogt
Status: Merged
Merged at revision: 3006
Proposed branch: lp://staging/~mvo/software-center/lp959612
Merge into: lp://staging/software-center/5.2
Diff against target: 27 lines (+1/-5)
2 files modified
softwarecenter/ui/gtk3/panes/availablepane.py (+0/-5)
softwarecenter/ui/gtk3/panes/installedpane.py (+1/-0)
To merge this branch: bzr merge lp://staging/~mvo/software-center/lp959612
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Dave Morley (community) testing the code did as expected Approve
Review via email: mp+105472@code.staging.launchpad.net

Description of the change

This branch fixes bug #955912. To reproduce:

1. open stock software-center
2. click on "installed" very quickly while the main page is still loading
3. verify that there is a traceback (note that this does not happen always, just most of the time)

4. use the fixed branch and the problem should be gone

I also removed unneeded code that displays the lobby page again when its finished loading to avoid a
jump back to the lobby.

To post a comment you must log in.
Revision history for this message
Dave Morley (davmor2) wrote :

Confirmed this code is now functioning as expexted for me, no trace back no transfer back to the lobby page either

review: Approve (testing the code did as expected)
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Looks good, you found the right spot for @wait_for_apt_cache_ready! Very nice!

Thanks, I will merge this now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches