Ubuntu Software Center

Merge lp://staging/~mvo/software-center/lp914393 into lp://staging/software-center

lp914393
Merge into trunk

Proposed by Michael Vogt on 2012-04-13

Status:	Merged
Merged at revision:	2971
Proposed branch:	lp://staging/~mvo/software-center/lp914393
Merge into:	lp://staging/software-center
Diff against target:	81 lines (+36/-7) 1 file modified softwarecenter/ui/gtk3/app.py (+36/-7)
To merge this branch:	bzr merge lp://staging/~mvo/software-center/lp914393
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Gary Lasker (community)		2012-04-13	Approve on 2012-04-13
Review via email: mp+101884@code.staging.launchpad.net

Description of the change

Based on lp:~mvo/software-center/lp772549 this branch adds a explicit sys.exit() to ensure all
gtk event processing stops. This works around the issue in bug #914393 where it appears that:

softwarecenter.ui.gtk3.view.appdetailsview.AppDetailsView calls
self.icon.set_from_pixbuf(pb) (in line 1379
even though the icon is already destroyed in the gtk/C world but not in the pygi/python world.

Revision history for this message

Michael Vogt (mvo) wrote on 2012-04-13:

Please note that the root of this crash is hopefully addressed with my patch for gtk+ in
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/938090/comments/11
but even with that we should still merge this branch to avoid getting hit by similar problems
(and because AFAICT there is no reason to exit right away).

Revision history for this message

Gary Lasker (gary-lasker) wrote on 2012-04-13:

Thank you Michael, this seems a good and very reasonable approach to fix this issue, and it will be great when we get your fix for the root problem into gtk+. Thanks! Approved and will merge now.

review: Approve