Merge lp://staging/~mvo/software-center/login-cleanup into lp://staging/software-center
Proposed by
Michael Vogt
| Status: | Merged |
|---|---|
| Merged at revision: | 3181 |
| Proposed branch: | lp://staging/~mvo/software-center/login-cleanup |
| Merge into: | lp://staging/software-center |
| Prerequisite: | lp://staging/~mvo/software-center/merge-prev-purchases-lp969273 |
| Diff against target: |
898 lines (+147/-506) 13 files modified
software-center (+0/-5) softwarecenter/backend/launchpad.py (+0/-341) softwarecenter/backend/login.py (+34/-1) softwarecenter/backend/login_impl/login_fake.py (+85/-0) softwarecenter/backend/login_impl/login_sso.py (+3/-84) softwarecenter/backend/oneconfhandler/core.py (+2/-2) softwarecenter/backend/ubuntusso.py (+6/-6) softwarecenter/ui/gtk3/app.py (+2/-20) softwarecenter/ui/gtk3/review_gui_helper.py (+2/-2) softwarecenter/ui/gtk3/widgets/recommendations.py (+2/-2) tests/disabled_test_launchpad.py (+0/-36) tests/gtk3/test_catview.py (+1/-1) tests/test_login_backend.py (+10/-6) |
| To merge this branch: | bzr merge lp://staging/~mvo/software-center/login-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Lasker (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Cleanup around the login backend code to make the naming better and to move the actual implementation of the login backend into softwarecenter.
Plus it removes a unused launchpad interfaces for private ppas that never got used nor does it work correctly.
To post a comment you must log in.
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Revision history for this message
| Gary Lasker (gary-lasker) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Should just be rename/reshuffle but still a careful look will be good.