Merge lp://staging/~mvo/software-center/launcher-integration-unit-tests into lp://staging/~gary-lasker/software-center/launcher-integration-unit-tests

Proposed by Michael Vogt
Status: Merged
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp://staging/~mvo/software-center/launcher-integration-unit-tests
Merge into: lp://staging/~gary-lasker/software-center/launcher-integration-unit-tests
Diff against target: 170 lines (+51/-74)
1 file modified
test/gtk3/test_unity_launcher_integration.py (+51/-74)
To merge this branch: bzr merge lp://staging/~mvo/software-center/launcher-integration-unit-tests
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Gary Lasker Pending
Review via email: mp+115489@code.staging.launchpad.net

Description of the change

This branch is the result of https://code.launchpad.net/~gary-lasker/software-center/launcher-integration-unit-tests/+merge/115236

The thing that needs a extra critical look is r3062 to ensure that this does not regress on what we are testing but if not I think its a good approach to simplify and remove some duplication.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Meh, r3062 (the commit message) is misleading as its just a subset (three tests) that are consolidated.

3063. By Michael Vogt

merged from gary

Revision history for this message
Michael Vogt (mvo) wrote :

Merged into 5.2 now (after approval from Gary on irc).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: