Merge lp://staging/~mvo/software-center/fix-clear-credentials-race into lp://staging/software-center
Proposed by
Michael Vogt
| Status: | Merged |
|---|---|
| Merged at revision: | 2995 |
| Proposed branch: | lp://staging/~mvo/software-center/fix-clear-credentials-race |
| Merge into: | lp://staging/software-center |
| Diff against target: |
107 lines (+23/-5) 4 files modified
softwarecenter/ui/gtk3/app.py (+4/-2) softwarecenter/utils.py (+11/-1) test/test_utils.py (+6/-0) utils/piston-helpers/piston_generic_helper.py (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~mvo/software-center/fix-clear-credentials-race |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Lasker (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch fixes a incorrect use of the sso dbus backend. The way it works is that we need to wait until
it emits a CredentialsCleared signal and that caused bug #986117.
The attached branch adds that wait (and a additional quit after 2s
just to ensure that it does not hang forever in case of failure of SSO). I also renamed the function to
ensure that its clear that its a sync call that may block the UI. Fortunately we only use it currently in
the backend code that is run in its own process. The app.py deauthorize code is never called but we need
to keep that in mind when that code is updated. I added a comment for this there.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks just great, and with it there is no sign of the previous error traceback as described in bug 986117. Very nice!