Merge lp://staging/~mvo/software-center/cookie-jar into lp://staging/software-center/5.2
Proposed by
Michael Vogt
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michael Nelson | ||||
| Approved revision: | 3054 | ||||
| Merged at revision: | 3053 | ||||
| Proposed branch: | lp://staging/~mvo/software-center/cookie-jar | ||||
| Merge into: | lp://staging/software-center/5.2 | ||||
| Diff against target: | 0 lines | ||||
| To merge this branch: | bzr merge lp://staging/~mvo/software-center/cookie-jar | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Nelson | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch adds a persistent cookie jar to software-center. This fixes the currently not working paypal method.
To test:
- open software-center
- try to purchase a app
- select paypal as the purchase method
- verify that the screen goes gray but no window opens and there is a error message on the terminal
this branch fixes the last problem. Bug reference #1018347
To post a comment you must log in.
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Great work finding a solution so quickly mvo. I'm guessing you'll be able to add a related test for the trunk version.
08:18 < mvo> could someone do a s-c review for me? https:/
08:19 < noodles> mvo: did you reply to ricardo's comment on the bug?
08:19 * noodles checks
08:19 < mvo> I did
08:20 < noodles> mvo: but wouldn't there need to be a logout somewhere on USC itself? (or, how do people get to the pay page where the order summary is from within USC's embedded browser?)
08:21 < noodles> mvo: Ah, you're clearing the cookies on each start?
08:21 < noodles> Sweet.
08:21 < noodles> Approving.
08:22 < mvo> noodles: I don't know :) I mean, it might be that USC would have to offer this, but I don't know what it would have to do, go to a special page to logout? clear some special cookies? happy to work on this once I know what pay needs but that is probably trunk material
08:22 < mvo> thanks a lot noodles, the removal is a bit of a heavy handed approach, but its not a regression, before we had no cookies at all
08:22 < noodles> Yep.