Merge lp://staging/~mvo/snapweb/new-snappy into lp://staging/~snappy-dev/snapweb/trunk

Proposed by Michael Vogt
Status: Approved
Approved by: Sergio Schvezov
Approved revision: 172
Proposed branch: lp://staging/~mvo/snapweb/new-snappy
Merge into: lp://staging/~snappy-dev/snapweb/trunk
Diff against target: 501 lines (+103/-128)
13 files modified
README.md (+20/-5)
avahi/avahi.go (+14/-10)
build.sh (+35/-9)
dependencies.tsv (+4/-2)
oem/oem.go (+5/-4)
pkg/meta/hooks/config (+0/-70)
pkg/meta/package.yaml (+2/-2)
pkg/snappyd (+6/-1)
snappy/common_test.go (+1/-1)
snappy/converge.go (+13/-21)
snappy/converge_test.go (+1/-1)
snappy/handlers.go (+1/-1)
webprogress/meter.go (+1/-1)
To merge this branch: bzr merge lp://staging/~mvo/snapweb/new-snappy
Reviewer Review Type Date Requested Status
Michael Vogt (community) Needs Fixing
Sergio Schvezov Approve
Review via email: mp+277433@code.staging.launchpad.net

Description of the change

Update webdm for new github snappy location and document some missing bits.

This also merges some bits from chipaca.

To post a comment you must log in.
lp://staging/~mvo/snapweb/new-snappy updated
169. By Michael Vogt

README.md: add missing gcc-aarch64-linux-gnu

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

mind merging all of Chipaca's changes?

lp://staging/~mvo/snapweb/new-snappy updated
170. By Michael Vogt

README.md: add missing ubuntu-snappy-cli dependency

171. By Michael Vogt

pkg/meta/package.yaml: use a string for the version

172. By Michael Vogt

merged lp:~chipaca/webdm/mdns-nicer-with-ipv6

Revision history for this message
Michael Vogt (mvo) wrote :

All of those should be merged now.

Revision history for this message
Sergio Schvezov (sergiusens) :
review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

Well, this is a mess. When I build this package I can not remove any snap from webdm. I get "Error: snappy package not found".

review: Needs Fixing
lp://staging/~mvo/snapweb/new-snappy updated
173. By Michael Vogt

bump version

174. By Michael Vogt

dependencies.tsv: use the latest 15.04 revno for the webdm build

175. By Michael Vogt

improve README.md, 15.10 is the only rev that can build webdm at this point

Revision history for this message
Michael Vogt (mvo) wrote :

Removing works now, I was a bad build (or rather a outdated dependencies.tsv). This works on 15.04 now.

However this will only work with 15.04 because its build with the 15.04 version of snappy and it will try to run sc-seccomp which is no longer available on 16.04. When build against the 16.04 snappy it will break on 15.04 because it expect the apparmor files in a different location.

So to summarize. We need a new webdm that works against the REST API or we need a webdm15.04 and a webdm16.04 in the store.

Revision history for this message
Michael Vogt (mvo) wrote :

Ups, "it was a bad build" of course.

Unmerged revisions

175. By Michael Vogt

improve README.md, 15.10 is the only rev that can build webdm at this point

174. By Michael Vogt

dependencies.tsv: use the latest 15.04 revno for the webdm build

173. By Michael Vogt

bump version

172. By Michael Vogt

merged lp:~chipaca/webdm/mdns-nicer-with-ipv6

171. By Michael Vogt

pkg/meta/package.yaml: use a string for the version

170. By Michael Vogt

README.md: add missing ubuntu-snappy-cli dependency

169. By Michael Vogt

README.md: add missing gcc-aarch64-linux-gnu

168. By Michael Vogt

we also need linux-libc-dev:i386

167. By Michael Vogt

its github.com now

166. By Michael Vogt

libc6-dev-i386 is also needed to build

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches