Ratings and Reviews server

Merge lp://staging/~mvo/rnr-server/make-port-configurable into lp://staging/rnr-server

  1. make-port-configurable
  2. Merge into trunk
Proposed by Michael Vogt
Status: Rejected
Rejected by: Michael Nelson
Proposed branch: lp://staging/~mvo/rnr-server/make-port-configurable
Merge into: lp://staging/rnr-server
Diff against target: 15 lines (+2/-1)
1 file modified
Makefile (+2/-1)
To merge this branch: bzr merge lp://staging/~mvo/rnr-server/make-port-configurable
Reviewer Review Type Date Requested Status
Ratings and Reviews Developers Pending
Review via email: mp+50901@code.staging.launchpad.net

Description of the change

This branch makes it possible to configure the port that the devserver runs on on the commandline, e.g:
$ make run port=5000

To post a comment you must log in.
Revision history for this message
Łukasz Czyżykowski (lukasz-czyzykowski) wrote :

If you set commit message tarmac will land it automatically.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

2011/2/23 Łukasz Czyżykowski <email address hidden>:
> If you set commit message tarmac will land it automatically.

but we don't want to land things at the moment (except your preflight
branch which landed, and danny's fix which is coming) :)

Revision history for this message
Michael Nelson (michael.nelson) wrote :

This change was included in another approved branch of mvo's.

Unmerged revisions

129. By Michael Vogt

Makefile: allow make run port=5000 type invocation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: